* Re: [tip:irq/core] powerpc: eeh: Fixup the brown paperbag fallout of the "cleanup"
[not found] <tip-57310c3c99eb6fab2ecbd63aa3f7c323341ca77e@git.kernel.org>
@ 2014-03-04 23:18 ` Benjamin Herrenschmidt
2014-03-04 23:29 ` Thomas Gleixner
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2014-03-04 23:18 UTC (permalink / raw)
To: linux-kernel, mingo, hpa, peterz, linuxppc-dev, tglx, shangw
Cc: linux-tip-commits
On Tue, 2014-03-04 at 15:15 -0800, tip-bot for Thomas Gleixner wrote:
> Commit-ID: 57310c3c99eb6fab2ecbd63aa3f7c323341ca77e
> Gitweb: http://git.kernel.org/tip/57310c3c99eb6fab2ecbd63aa3f7c323341ca77e
> Author: Thomas Gleixner <tglx@linutronix.de>
> AuthorDate: Wed, 5 Mar 2014 00:06:11 +0100
> Committer: Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Wed, 5 Mar 2014 00:13:33 +0100
>
> powerpc: eeh: Fixup the brown paperbag fallout of the "cleanup"
>
> Commit b8a9a11b9 (powerpc: eeh: Kill another abuse of irq_desc) is
> missing some brackets .....
>
> It's not a good idea to write patches in grumpy mode and then forget
> to at least compile test them or rely on the few eyeballs discussing
> that patch to spot it.....
Ouch :-)
Next time you have a series like that, if you want I'll throw it at my
build tester.
Cheers,
Ben.
> Reported-by: fengguang.wu@intel.com
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Gavin Shan <shangw@linux.vnet.ibm.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: ppc <linuxppc-dev@lists.ozlabs.org>
> ---
> arch/powerpc/kernel/eeh_driver.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/eeh_driver.c b/arch/powerpc/kernel/eeh_driver.c
> index 3e1d7de..bb61ca5 100644
> --- a/arch/powerpc/kernel/eeh_driver.c
> +++ b/arch/powerpc/kernel/eeh_driver.c
> @@ -166,8 +166,9 @@ static void eeh_enable_irq(struct pci_dev *dev)
> *
> * tglx
> */
> - if (irqd_irq_disabled(irq_get_irq_data(dev->irq))
> + if (irqd_irq_disabled(irq_get_irq_data(dev->irq)))
> enable_irq(dev->irq);
> + }
> }
>
> /**
^ permalink raw reply [flat|nested] 2+ messages in thread