From: Venkatesh Srinivas <venkateshs@google.com>
To: eranian@google.com, linux-kernel@vger.kernel.org
Cc: Venkatesh Srinivas <venkateshs@google.com>
Subject: [PATCH] perf/x86/intel: Use rdmsrl_safe when initializing RAPL PMU.
Date: Thu, 6 Mar 2014 20:42:44 -0800 [thread overview]
Message-ID: <1394167364-2389-1-git-send-email-venkateshs@google.com> (raw)
CPUs which should support the RAPL counters according to
Family/Model/Stepping may still issue #GP when attempting to access
the RAPL MSRs. This may happen when Linux is running under KVM and
we are passing-through host F/M/S data, for example. Use rdmsrl_safe
to first access the RAPL_POWER_UNIT MSR; if this fails, do not
attempt to use this PMU.
Signed-off-by: Venkatesh Srinivas <venkateshs@google.com>
---
arch/x86/kernel/cpu/perf_event_intel_rapl.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/cpu/perf_event_intel_rapl.c b/arch/x86/kernel/cpu/perf_event_intel_rapl.c
index 5ad35ad..95700e5 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_rapl.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_rapl.c
@@ -511,6 +511,7 @@ static int rapl_cpu_prepare(int cpu)
struct rapl_pmu *pmu = per_cpu(rapl_pmu, cpu);
int phys_id = topology_physical_package_id(cpu);
u64 ms;
+ u64 msr_rapl_power_unit_bits;
if (pmu)
return 0;
@@ -518,6 +519,9 @@ static int rapl_cpu_prepare(int cpu)
if (phys_id < 0)
return -1;
+ if (!rdmsrl_safe(MSR_RAPL_POWER_UNIT, &msr_rapl_power_unit_bits))
+ return -1;
+
pmu = kzalloc_node(sizeof(*pmu), GFP_KERNEL, cpu_to_node(cpu));
if (!pmu)
return -1;
@@ -531,8 +535,7 @@ static int rapl_cpu_prepare(int cpu)
*
* we cache in local PMU instance
*/
- rdmsrl(MSR_RAPL_POWER_UNIT, pmu->hw_unit);
- pmu->hw_unit = (pmu->hw_unit >> 8) & 0x1FULL;
+ pmu->hw_unit = (msr_rapl_power_unit_bits >> 8) & 0x1FULL;
pmu->pmu = &rapl_pmu_class;
/*
@@ -649,7 +652,9 @@ static int __init rapl_pmu_init(void)
get_online_cpus();
for_each_online_cpu(cpu) {
- rapl_cpu_prepare(cpu);
+ ret = rapl_cpu_prepare(cpu);
+ if (ret)
+ goto out;
rapl_cpu_init(cpu);
}
@@ -672,6 +677,7 @@ static int __init rapl_pmu_init(void)
hweight32(rapl_cntr_mask),
ktime_to_ms(pmu->timer_interval));
+out:
put_online_cpus();
return 0;
--
1.9.0.279.gdc9e3eb
next reply other threads:[~2014-03-07 4:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 4:42 Venkatesh Srinivas [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-03-13 19:36 [PATCH] perf/x86/intel: Use rdmsrl_safe when initializing RAPL PMU Venkatesh Srinivas
2014-03-14 8:44 ` Peter Zijlstra
2014-03-14 13:56 ` Andi Kleen
2014-03-14 15:21 ` Venkatesh Srinivas
2014-03-14 16:17 ` Andi Kleen
2014-03-14 16:57 ` David Ahern
2014-03-14 23:07 ` Venkatesh Srinivas
2014-04-23 14:31 ` Stephane Eranian
2014-04-23 14:45 ` Peter Zijlstra
2014-04-23 14:49 ` Stephane Eranian
2014-04-23 15:09 ` Peter Zijlstra
2014-04-23 15:14 ` Stephane Eranian
2014-04-23 15:16 ` Borislav Petkov
2014-04-23 15:18 ` Stephane Eranian
2014-04-23 15:35 ` Borislav Petkov
2014-04-23 15:44 ` Stephane Eranian
2014-04-23 15:55 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394167364-2389-1-git-send-email-venkateshs@google.com \
--to=venkateshs@google.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox