From: Paul Bolle <pebolle@tiscali.nl>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Jerome Oufella <jerome.oufella@savoirfairelinux.com>,
Julian Wollrath <jwollrath@web.de>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND] Fast TSC calibration fails with v3.14-rc1 and later
Date: Tue, 11 Mar 2014 00:06:29 +0100 [thread overview]
Message-ID: <1394492789.16134.36.camel@x220> (raw)
In-Reply-To: <alpine.DEB.2.02.1403102122310.18573@ionos.tec.linutronix.de>
On Mon, 2014-03-10 at 21:50 +0100, Thomas Gleixner wrote:
> On Mon, 10 Mar 2014, Paul Bolle wrote:
> > So could you please consider downgrading this message?
> >
> > Yes, this will make regressions less visible, although I'm unsure we're
> > actually seeing a regression here. But I think that this is better than
> > scaring people about a situation they can't easily do something about,
> > if at all. Especially since fast TSC calibration failures, apparently,
> > can be worked around.
>
> If something works fine from version X up to v3.13 and then suddenly
> fails, then we can safely ignore it because there is a work around or
> fallback? And just shrug and say: Oh, it's not a regression.
That's not what I said, not at all. Saying that "I'm unsure we're
actually seeing a regression" is not shrugging it off.
> Dammit no. We want to know WHY!
Here I am one and half year after reporting seeing this error. I'm not
aware of anyone reporting it before me. Anyhow, I don't think things
were working fine up to v3.13. And in my report (I'm not going to link
to it again) I suggested to downgrade this message. My exact words were:
So, without even understanding why tsc calibration is needed, it does
look unnecessary to print "Fast TSC calibration failed" at error level.
If that's correct, I'd be happy to submit the trivial patch to downgrade
it to (say) informational level.
Which was fine with hpa (added in CC).
I actually submitted that patch, sent a reminder, and Jerome sent a
similar patch. Most of that was directly sent to you too. I don't think
we got any reaction whatsoever. And, still, suggesting this is not a
regression and reiterating that this could also be printed at something
else than error level somehow provoked your outburst.
I'd like to discuss a way forward. But could you please _try_ to
understand why I said what I said in this discussion?
Paul Bolle
next prev parent reply other threads:[~2014-03-10 23:06 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 10:04 [RESEND] Fast TSC calibration fails with v3.14-rc1 and later Julian Wollrath
2014-03-10 10:27 ` Paul Bolle
2014-03-10 14:06 ` Thomas Gleixner
2014-03-10 15:28 ` Paul Bolle
2014-03-10 17:04 ` Thomas Gleixner
2014-03-10 18:32 ` Paul Bolle
2014-03-10 18:57 ` Thomas Gleixner
2014-03-10 19:19 ` Paul Bolle
2014-03-10 20:50 ` Thomas Gleixner
2014-03-10 23:06 ` Paul Bolle [this message]
2014-03-11 16:02 ` Thomas Gleixner
2014-03-11 13:27 ` Julian Wollrath
2014-03-10 10:39 ` Thomas Gleixner
2014-03-11 13:29 ` Julian Wollrath
2014-03-11 13:56 ` Thomas Gleixner
2014-03-11 17:15 ` Julian Wollrath
2014-03-12 4:00 ` joeyli
2014-03-12 10:20 ` Julian Wollrath
2014-03-12 13:52 ` joeyli
2014-03-12 11:20 ` Rafael J. Wysocki
2014-03-12 13:30 ` Rafael J. Wysocki
2014-03-12 13:55 ` Julian Wollrath
2014-03-12 15:41 ` joeyli
2014-03-12 16:20 ` Thomas Gleixner
2014-03-12 16:23 ` Thomas Gleixner
2014-03-12 16:39 ` Thomas Gleixner
2014-03-12 23:27 ` Rafael J. Wysocki
2014-03-12 23:49 ` Thomas Gleixner
2014-03-13 0:13 ` Rafael J. Wysocki
2014-03-13 2:56 ` joeyli
2014-03-13 0:54 ` Thomas Gleixner
2014-03-13 1:01 ` Thomas Gleixner
2014-03-13 2:38 ` joeyli
2014-03-13 3:11 ` H. Peter Anvin
2014-03-13 3:55 ` joeyli
2014-03-13 3:59 ` H. Peter Anvin
2014-03-13 4:12 ` joeyli
2014-03-13 8:12 ` Thomas Gleixner
2014-03-13 8:59 ` joeyli
2014-03-13 3:41 ` H. Peter Anvin
2014-03-12 14:00 ` joeyli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394492789.16134.36.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=hpa@zytor.com \
--cc=jerome.oufella@savoirfairelinux.com \
--cc=jwollrath@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox