Re: [PATCH] perf/x86/intel: Use rdmsrl_safe when initializing RAPL PMU.

Stephane Eranian
2014-04-23T15:18:36Z

On Wed, Apr 23, 2014 at 5:16 PM, Borislav Petkov <bp@alien8.de> wrote:
> On Wed, Apr 23, 2014 at 05:14:33PM +0200, Stephane Eranian wrote:
>> Wouldn't rdmsrl_safe() return 0 on success?
>
> Yes.
>
then the if() test is wrong:
if (!rdmsrl_safe())
return -1;

Should be:
if (rdmsrl_safe())
return -1;

Or am I missing something?

> --
> Regards/Gruss,
> Boris.
>
> Sent from a fat crate under my desk. Formatting is fine.
> --