From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
Andi Kleen <andi@firstfloor.org>, David Ahern <dsahern@gmail.com>,
Jiri Olsa <jolsa@redhat.com>, Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 04/13] perf symbols: Apply all filters to an addr_location
Date: Tue, 18 Mar 2014 18:25:56 -0300 [thread overview]
Message-ID: <1395177965-8879-5-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1395177965-8879-1-git-send-email-acme@infradead.org>
From: Namhyung Kim <namhyung@kernel.org>
Instead of bailing out as soon as we find a filter that applies, go on
checking all of them so that we can zoom in/out filters.
We also need to make sure we only update al->filtered after
thread__find_addr_map(), because there is where al->filtered gets
initialized to zero.
This will increase the cost of processing when all we don't need this
toggling, but will provide flexibility for the TUI and GTK+ interfaces,
that will incur in creating the hist_entries just once.
Signed-off-by: Namhyung Kim <namhyung.kim@lge.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung.kim@lge.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/n/tip-fhv9lhzdjxgp9w3w3668lsfw@git.kernel.org
[ yanked this out of a previous patch ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/event.c | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index 0da09db5f9f6..ebb48a623407 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -793,11 +793,6 @@ int perf_event__preprocess_sample(const union perf_event *event,
if (thread == NULL)
return -1;
- if (thread__is_filtered(thread)) {
- al->filtered |= (1 << HIST_FILTER__THREAD);
- goto out_filtered;
- }
-
dump_printf(" ... thread: %s:%d\n", thread__comm_str(thread), thread->tid);
/*
* Have we already created the kernel maps for this machine?
@@ -815,6 +810,10 @@ int perf_event__preprocess_sample(const union perf_event *event,
dump_printf(" ...... dso: %s\n",
al->map ? al->map->dso->long_name :
al->level == 'H' ? "[hypervisor]" : "<not found>");
+
+ if (thread__is_filtered(thread))
+ al->filtered |= (1 << HIST_FILTER__THREAD);
+
al->sym = NULL;
al->cpu = sample->cpu;
@@ -828,7 +827,6 @@ int perf_event__preprocess_sample(const union perf_event *event,
strlist__has_entry(symbol_conf.dso_list,
dso->long_name))))) {
al->filtered |= (1 << HIST_FILTER__DSO);
- goto out_filtered;
}
al->sym = map__find_symbol(al->map, al->addr,
@@ -839,11 +837,7 @@ int perf_event__preprocess_sample(const union perf_event *event,
(!al->sym || !strlist__has_entry(symbol_conf.sym_list,
al->sym->name))) {
al->filtered |= (1 << HIST_FILTER__SYMBOL);
- goto out_filtered;
}
return 0;
-
-out_filtered:
- return 0;
}
--
1.8.1.4
next prev parent reply other threads:[~2014-03-18 21:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 21:25 [GIT PULL 00/13] perf/core improvements and fixes Arnaldo Carvalho de Melo
2014-03-18 21:25 ` [PATCH 01/13] perf timechart: Fix off-by-one error in 'record' argv handling Arnaldo Carvalho de Melo
2014-03-18 21:25 ` [PATCH 02/13] perf sched: Fixup header alignment in 'latency' output Arnaldo Carvalho de Melo
2014-03-18 21:25 ` [PATCH 03/13] perf symbols: Record the reason for filtering an address_location Arnaldo Carvalho de Melo
2014-03-18 21:25 ` Arnaldo Carvalho de Melo [this message]
2014-03-18 21:25 ` [PATCH 05/13] perf report: Merge al->filtered with hist_entry->filtered Arnaldo Carvalho de Melo
2014-03-18 21:25 ` [PATCH 06/13] perf tools: Use tid in mmap/mmap2 events to find maps Arnaldo Carvalho de Melo
2014-03-19 7:13 ` Adrian Hunter
2014-03-19 10:19 ` Jiri Olsa
[not found] ` <20140319131945.GW25953@redhat.com>
2014-03-19 13:30 ` Jiri Olsa
2014-03-19 14:27 ` Adrian Hunter
2014-03-19 14:43 ` Don Zickus
2014-03-19 15:17 ` Adrian Hunter
2014-03-20 14:44 ` Arnaldo Carvalho de Melo
2014-03-18 21:25 ` [PATCH 07/13] perf tools: Fix memory leak when synthesizing thread records Arnaldo Carvalho de Melo
2014-03-18 21:26 ` [PATCH 08/13] perf report: Use ui__has_annotation() Arnaldo Carvalho de Melo
2014-03-18 21:26 ` [PATCH 09/13] perf annotate: Print the evsel name in the stdio output Arnaldo Carvalho de Melo
2014-03-18 21:26 ` [PATCH 10/13] perf tools: Remove thread__find_map function Arnaldo Carvalho de Melo
2014-03-18 21:26 ` [PATCH 11/13] perf evsel: Update function names in debug messages Arnaldo Carvalho de Melo
2014-03-18 21:26 ` [PATCH 12/13] perf tools: Update some code references in design.txt Arnaldo Carvalho de Melo
2014-03-18 21:26 ` [PATCH 13/13] perf tools: Remove unused simple_strtoul() function Arnaldo Carvalho de Melo
2014-03-19 7:07 ` [GIT PULL 00/13] perf/core improvements and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395177965-8879-5-git-send-email-acme@infradead.org \
--to=acme@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).