From: Joe Perches <joe@perches.com>
To: "Cédric Cabessa" <ced@ryick.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] coding style: fix quoted string split across lines
Date: Thu, 20 Mar 2014 04:06:40 -0700 [thread overview]
Message-ID: <1395313600.7776.14.camel@joe-AO722> (raw)
In-Reply-To: <1395266697-8699-2-git-send-email-ced@ryick.net>
On Wed, 2014-03-19 at 23:04 +0100, Cédric Cabessa wrote:
[]
> diff --git a/drivers/staging/usbip/usbip_common.c b/drivers/staging/usbip/usbip_common.c
[]
> @@ -178,8 +178,8 @@ static void usbip_dump_usb_ctrlrequest(struct usb_ctrlrequest *cmd)
> }
>
> pr_debug(" ");
> - pr_debug("bRequestType(%02X) bRequest(%02X) wValue(%04X) wIndex(%04X) "
> - "wLength(%04X) ", cmd->bRequestType, cmd->bRequest,
> + pr_debug("bRequestType(%02X) bRequest(%02X) wValue(%04X) wIndex(%04X) wLength(%04X) ",
> + cmd->bRequestType, cmd->bRequest,
> cmd->wValue, cmd->wIndex, cmd->wLength);
> pr_debug("\n ");
While you didn't change it, these uses are broken.
pr_debug always starts a new line so the continuations
attempted in this block don't work.
Likely this was originally converted from some non pr_debug
mechanism without an understanding of how pr_debug varies
from a normal printf.
next prev parent reply other threads:[~2014-03-20 11:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 22:04 [PATCH 0/2] coding style for drivers/staging/usbip Cédric Cabessa
2014-03-19 22:04 ` [PATCH 1/2] coding style: fix quoted string split across lines Cédric Cabessa
2014-03-20 1:49 ` Greg Kroah-Hartman
2014-03-20 11:06 ` Joe Perches [this message]
2014-03-19 22:04 ` [PATCH 2/2] coding style: fix line over 80 characters Cédric Cabessa
2014-03-20 21:34 ` Sergei Shtylyov
2014-03-20 20:45 ` Joe Perches
2014-03-20 22:23 ` Sergei Shtylyov
2014-03-20 21:38 ` Sergei Shtylyov
2014-03-21 1:54 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395313600.7776.14.camel@joe-AO722 \
--to=joe@perches.com \
--cc=ced@ryick.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox