* [PATCH 1/2] regulator: s2mpa01: Don't check enable_shift before setting enable ramp rate
@ 2014-03-21 8:15 Axel Lin
2014-03-21 8:16 ` [PATCH 2/2] regulator: s2mps11: " Axel Lin
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Axel Lin @ 2014-03-21 8:15 UTC (permalink / raw)
To: Mark Brown
Cc: Sachin Kamat, Krzysztof Kozlowski, Sangbeom Kim, Liam Girdwood,
linux-kernel
Current code misses updating the register when enable_shift is 0.
e.g. S2MPA01_BUCK4_RAMP_EN_SHIFT is 0.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/s2mpa01.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/regulator/s2mpa01.c b/drivers/regulator/s2mpa01.c
index 808b3aa..f19a30f 100644
--- a/drivers/regulator/s2mpa01.c
+++ b/drivers/regulator/s2mpa01.c
@@ -192,13 +192,11 @@ static int s2mpa01_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay)
if (!ramp_enable)
goto ramp_disable;
- if (enable_shift) {
- ret = regmap_update_bits(rdev->regmap, S2MPA01_REG_RAMP1,
- 1 << enable_shift, 1 << enable_shift);
- if (ret) {
- dev_err(&rdev->dev, "failed to enable ramp rate\n");
- return ret;
- }
+ ret = regmap_update_bits(rdev->regmap, S2MPA01_REG_RAMP1,
+ 1 << enable_shift, 1 << enable_shift);
+ if (ret) {
+ dev_err(&rdev->dev, "failed to enable ramp rate\n");
+ return ret;
}
ramp_val = get_ramp_delay(ramp_delay);
--
1.8.3.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/2] regulator: s2mps11: Don't check enable_shift before setting enable ramp rate
2014-03-21 8:15 [PATCH 1/2] regulator: s2mpa01: Don't check enable_shift before setting enable ramp rate Axel Lin
@ 2014-03-21 8:16 ` Axel Lin
2014-04-01 7:02 ` Krzysztof Kozlowski
2014-04-02 19:54 ` Mark Brown
2014-04-01 4:03 ` [PATCH 1/2] regulator: s2mpa01: " Axel Lin
` (2 subsequent siblings)
3 siblings, 2 replies; 7+ messages in thread
From: Axel Lin @ 2014-03-21 8:16 UTC (permalink / raw)
To: Mark Brown
Cc: Sachin Kamat, Krzysztof Kozlowski, Sangbeom Kim, Liam Girdwood,
linux-kernel
Current code misses updating the register when enable_shift is 0.
e.g. S2MPS11_BUCK9_RAMP_SHIFT and S2MPS11_BUCK6_RAMP_EN_SHIFT are 0.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/s2mps11.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c
index 68fd547..e713c16 100644
--- a/drivers/regulator/s2mps11.c
+++ b/drivers/regulator/s2mps11.c
@@ -202,13 +202,11 @@ static int s2mps11_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay)
if (!ramp_enable)
goto ramp_disable;
- if (enable_shift) {
- ret = regmap_update_bits(rdev->regmap, S2MPS11_REG_RAMP,
- 1 << enable_shift, 1 << enable_shift);
- if (ret) {
- dev_err(&rdev->dev, "failed to enable ramp rate\n");
- return ret;
- }
+ ret = regmap_update_bits(rdev->regmap, S2MPS11_REG_RAMP,
+ 1 << enable_shift, 1 << enable_shift);
+ if (ret) {
+ dev_err(&rdev->dev, "failed to enable ramp rate\n");
+ return ret;
}
ramp_val = get_ramp_delay(ramp_delay);
--
1.8.3.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] regulator: s2mps11: Don't check enable_shift before setting enable ramp rate
2014-03-21 8:16 ` [PATCH 2/2] regulator: s2mps11: " Axel Lin
@ 2014-04-01 7:02 ` Krzysztof Kozlowski
2014-04-02 19:54 ` Mark Brown
1 sibling, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2014-04-01 7:02 UTC (permalink / raw)
To: Axel Lin
Cc: Mark Brown, Sachin Kamat, Sangbeom Kim, Liam Girdwood,
linux-kernel
On Fri, 2014-03-21 at 16:16 +0800, Axel Lin wrote:
> Current code misses updating the register when enable_shift is 0.
> e.g. S2MPS11_BUCK9_RAMP_SHIFT and S2MPS11_BUCK6_RAMP_EN_SHIFT are 0.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/s2mps11.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
Looks good.
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
> diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c
> index 68fd547..e713c16 100644
> --- a/drivers/regulator/s2mps11.c
> +++ b/drivers/regulator/s2mps11.c
> @@ -202,13 +202,11 @@ static int s2mps11_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay)
> if (!ramp_enable)
> goto ramp_disable;
>
> - if (enable_shift) {
> - ret = regmap_update_bits(rdev->regmap, S2MPS11_REG_RAMP,
> - 1 << enable_shift, 1 << enable_shift);
> - if (ret) {
> - dev_err(&rdev->dev, "failed to enable ramp rate\n");
> - return ret;
> - }
> + ret = regmap_update_bits(rdev->regmap, S2MPS11_REG_RAMP,
> + 1 << enable_shift, 1 << enable_shift);
> + if (ret) {
> + dev_err(&rdev->dev, "failed to enable ramp rate\n");
> + return ret;
> }
>
> ramp_val = get_ramp_delay(ramp_delay);
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] regulator: s2mps11: Don't check enable_shift before setting enable ramp rate
2014-03-21 8:16 ` [PATCH 2/2] regulator: s2mps11: " Axel Lin
2014-04-01 7:02 ` Krzysztof Kozlowski
@ 2014-04-02 19:54 ` Mark Brown
1 sibling, 0 replies; 7+ messages in thread
From: Mark Brown @ 2014-04-02 19:54 UTC (permalink / raw)
To: Axel Lin
Cc: Sachin Kamat, Krzysztof Kozlowski, Sangbeom Kim, Liam Girdwood,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 215 bytes --]
On Fri, Mar 21, 2014 at 04:16:24PM +0800, Axel Lin wrote:
> Current code misses updating the register when enable_shift is 0.
> e.g. S2MPS11_BUCK9_RAMP_SHIFT and S2MPS11_BUCK6_RAMP_EN_SHIFT are 0.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] regulator: s2mpa01: Don't check enable_shift before setting enable ramp rate
2014-03-21 8:15 [PATCH 1/2] regulator: s2mpa01: Don't check enable_shift before setting enable ramp rate Axel Lin
2014-03-21 8:16 ` [PATCH 2/2] regulator: s2mps11: " Axel Lin
@ 2014-04-01 4:03 ` Axel Lin
2014-04-01 6:27 ` Sachin Kamat
2014-04-02 19:52 ` Mark Brown
3 siblings, 0 replies; 7+ messages in thread
From: Axel Lin @ 2014-04-01 4:03 UTC (permalink / raw)
To: Mark Brown
Cc: Sachin Kamat, Krzysztof Kozlowski, Sangbeom Kim, Liam Girdwood,
linux-kernel@vger.kernel.org
2014-03-21 16:15 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
> Current code misses updating the register when enable_shift is 0.
> e.g. S2MPA01_BUCK4_RAMP_EN_SHIFT is 0.
Hi Sachin and Krzysztof,
I think these 2 patches are bug fix.
Any comment on this patch serial?
Regards,
Axel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] regulator: s2mpa01: Don't check enable_shift before setting enable ramp rate
2014-03-21 8:15 [PATCH 1/2] regulator: s2mpa01: Don't check enable_shift before setting enable ramp rate Axel Lin
2014-03-21 8:16 ` [PATCH 2/2] regulator: s2mps11: " Axel Lin
2014-04-01 4:03 ` [PATCH 1/2] regulator: s2mpa01: " Axel Lin
@ 2014-04-01 6:27 ` Sachin Kamat
2014-04-02 19:52 ` Mark Brown
3 siblings, 0 replies; 7+ messages in thread
From: Sachin Kamat @ 2014-04-01 6:27 UTC (permalink / raw)
To: Axel Lin; +Cc: Mark Brown, Krzysztof Kozlowski, Sangbeom Kim, Liam Girdwood,
LKML
Hi Axel,
On 21 March 2014 13:45, Axel Lin <axel.lin@ingics.com> wrote:
> Current code misses updating the register when enable_shift is 0.
> e.g. S2MPA01_BUCK4_RAMP_EN_SHIFT is 0.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Sachin Kamat <sachin.kamat@linaro.org>
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] regulator: s2mpa01: Don't check enable_shift before setting enable ramp rate
2014-03-21 8:15 [PATCH 1/2] regulator: s2mpa01: Don't check enable_shift before setting enable ramp rate Axel Lin
` (2 preceding siblings ...)
2014-04-01 6:27 ` Sachin Kamat
@ 2014-04-02 19:52 ` Mark Brown
3 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2014-04-02 19:52 UTC (permalink / raw)
To: Axel Lin
Cc: Sachin Kamat, Krzysztof Kozlowski, Sangbeom Kim, Liam Girdwood,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 185 bytes --]
On Fri, Mar 21, 2014 at 04:15:20PM +0800, Axel Lin wrote:
> Current code misses updating the register when enable_shift is 0.
> e.g. S2MPA01_BUCK4_RAMP_EN_SHIFT is 0.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-04-02 19:54 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-21 8:15 [PATCH 1/2] regulator: s2mpa01: Don't check enable_shift before setting enable ramp rate Axel Lin
2014-03-21 8:16 ` [PATCH 2/2] regulator: s2mps11: " Axel Lin
2014-04-01 7:02 ` Krzysztof Kozlowski
2014-04-02 19:54 ` Mark Brown
2014-04-01 4:03 ` [PATCH 1/2] regulator: s2mpa01: " Axel Lin
2014-04-01 6:27 ` Sachin Kamat
2014-04-02 19:52 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox