Re: [PATCH 1/2] dt/bindings: add binding for ARM Versatile character LCD

Dinh Nguyen
2014-03-28T22:15:26Z

On Fri, 2014-03-28 at 16:48 -0500, Rob Herring wrote:
> On Fri, Mar 28, 2014 at 4:35 PM, Dinh Nguyen <dinguyen@altera.com> wrote:
> > On Fri, 2014-03-28 at 16:20 -0500, Rob Herring wrote:
> >> From: Rob Herring <robh@kernel.org>
> >>
> >> Add binding doc for Versatile platforms character LCD controller
> >> interface.
> >>
> >> Signed-off-by: Rob Herring <robh@kernel.org>
> >> Cc: Pawel Moll <pawel.moll@arm.com>
> >> Cc: Mark Rutland <mark.rutland@arm.com>
> >> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> >> Cc: Kumar Gala <galak@codeaurora.org>
> >> ---
> >> Documentation/devicetree/bindings/misc/arm-charlcd.txt | 18 ++++++++++++++++++
> >> 1 file changed, 18 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/misc/arm-charlcd.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/misc/arm-charlcd.txt b/Documentation/devicetree/bindings/misc/arm-charlcd.txt
> >> new file mode 100644
> >> index 0000000..e28e2aa
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/misc/arm-charlcd.txt
> >> @@ -0,0 +1,18 @@
> >> +ARM Versatile Character LCD
> >> +-----------------------------------------------------
> >> +This binding defines the character LCD interface found on ARM Versatile AB
> >> +and PB reference platforms.
> >> +
> >> +Required properties:
> >> +- compatible : "arm,versatile-clcd"
> >
> > Should this be "arm,versatile-lcd"?
>
> Make up your mind. ;) -lcd is what is already used in the dts, but
> since there was no driver support it should be okay to change the dts.
> If we're changing, I think I'll change it to "arm,versatile-char-lcd".
> 'c' alone could just mean color.

Sorry...what I meant was that in your patch, the examples was using
"lcd", and here's its "clcd". Then your 2/2 patch is using "lcd".

Dinh
>
> Rob