[RFC] quiet checkpatch style recommendation about no spaces around bitfield :

Joe Perches
2014-03-31T15:31:49Z

On Mon, 2014-03-31 at 18:06 +0300, Dan Carpenter wrote:
> On Mon, Mar 31, 2014 at 02:34:40PM +0200, Rocco Folino wrote:
> > Fixed bit fields code style issues
[]
> > diff --git a/drivers/staging/octeon-usb/octeon-hcd.h b/drivers/staging/octeon-usb/octeon-hcd.h
[]
> > @@ -143,13 +143,13 @@ union cvmx_usbcx_gahbcfg {
> > * * 1'b1: Unmask the interrupt assertion to the application.
> > */
> > struct cvmx_usbcx_gahbcfg_s {
> > - uint32_t reserved_9_31 : 23;
> > - uint32_t ptxfemplvl : 1;
> > - uint32_t nptxfemplvl : 1;
> > - uint32_t reserved_6_6 : 1;
> > - uint32_t dmaen : 1;
> > - uint32_t hbstlen : 4;
> > - uint32_t glblintrmsk : 1;
> > + uint32_t reserved_9_31:23;
> > + uint32_t ptxfemplvl:1;
> > + uint32_t nptxfemplvl:1;
> > + uint32_t reserved_6_6:1;
> > + uint32_t dmaen:1;
> > + uint32_t hbstlen:4;
> > + uint32_t glblintrmsk:1;
> > } s;
> The warning here is:
> ERROR: spaces prohibited around that ':' (ctx:WxW)
> I have done a kernel wide search for these warnings

Really? How?

> and I think we
> should disable this warning. It has too many false positives like this.

It does seem a bit noisy to me too.

Andy? Andrew?

>From a treewide checkpatch scan next-20140307:

$ grep "spaces prohibited around that ':' (ctx:WxW)" checkpatch.all | wc -l
11194

I don't see any other uses of that message for
anything other than bitfields.