linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jon Mason <jon.mason@intel.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH 1/9] ntb_netdev: Fix list_for_each_entry exit issue
Date: Mon,  7 Apr 2014 17:52:46 -0700	[thread overview]
Message-ID: <1396918374-5196-2-git-send-email-jon.mason@intel.com> (raw)
In-Reply-To: <1396918374-5196-1-git-send-email-jon.mason@intel.com>

If list_for_each_entry exits without finding the ntb_device, the dev
pointer will not be NULL.  Thus the check will never be true and the
code will not exit when it should.  Correct this by adding a bool to
determine when the device is found, otherwise exit in good fashion.

Signed-off-by: Jon Mason <jon.mason@intel.com>
---
 drivers/net/ntb_netdev.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ntb_netdev.c b/drivers/net/ntb_netdev.c
index f3cdf64..8298880 100644
--- a/drivers/net/ntb_netdev.c
+++ b/drivers/net/ntb_netdev.c
@@ -367,12 +367,15 @@ static void ntb_netdev_remove(struct pci_dev *pdev)
 {
 	struct net_device *ndev;
 	struct ntb_netdev *dev;
+	bool found  = false;
 
 	list_for_each_entry(dev, &dev_list, list) {
-		if (dev->pdev == pdev)
+		if (dev->pdev == pdev) {
+			found = true;
 			break;
+		}
 	}
-	if (dev == NULL)
+	if (!found)
 		return;
 
 	list_del(&dev->list);
-- 
1.8.3.2


  reply	other threads:[~2014-04-08  0:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-08  0:52 [PATCH 0/9] NTB Update Jon Mason
2014-04-08  0:52 ` Jon Mason [this message]
2014-04-08  0:52 ` [PATCH 2/9] ntb_netdev: Fix skb free issue in open Jon Mason
2014-04-08  0:52 ` [PATCH 3/9] NTB: Fix typo in setting one translation register Jon Mason
2014-04-08  0:52 ` [PATCH 4/9] ntb: Fix leakage of ntb_device::msix_entries[] array Jon Mason
2014-04-08  0:52 ` [PATCH 5/9] NTB: client event cleanup Jon Mason
2014-04-08  0:52 ` [PATCH 6/9] NTB: Code Style Clean-up Jon Mason
2014-04-08  0:52 ` [PATCH 7/9] ntb: Use pci_msix_vec_count() to obtain number of MSI-Xs Jon Mason
2014-04-08  0:52 ` [PATCH 8/9] ntb: Split ntb_setup_msix() into separate BWD/SNB routines Jon Mason
2014-04-08  0:52 ` [PATCH 9/9] ntb: Use pci_enable_msix_range() instead of pci_enable_msix() Jon Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1396918374-5196-2-git-send-email-jon.mason@intel.com \
    --to=jon.mason@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).