From: Joe Perches <joe@perches.com>
To: Rob Herring <robherring2@gmail.com>
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>,
Andy Whitcroft <apw@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] checkpatch: skip directories in file checking mode
Date: Tue, 08 Apr 2014 08:06:36 -0700 [thread overview]
Message-ID: <1396969596.2812.9.camel@joe-AO722> (raw)
In-Reply-To: <1396963505-11119-2-git-send-email-robherring2@gmail.com>
On Tue, 2014-04-08 at 08:25 -0500, Rob Herring wrote:
> From: Rob Herring <robh@kernel.org>
>
> Running checkpatch.pl on a list of files using a wildcard will exit if
> a directory is encountered. For example:
>
> $ scripts/checkpatch.pl -f arch/*
> diff: arch/alpha/null: No such file or directory
>
> The correct operation is arch/Kconfig should be checked. Fix this by
> skipping files which are not regular files.
<shrug>
You could make the same argument that it should
skip .o files if you fed it to checkpatch on the
command line.
I think the correct thing is to feed only files
you want scanned to checkpatch.
git ls-files arch/ | xargs ./scripts/checkpatch.pl -f
next prev parent reply other threads:[~2014-04-08 15:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 13:25 [PATCH 1/2] checkpatch: fix wildcard DT compatible string checking Rob Herring
2014-04-08 13:25 ` [PATCH 2/2] checkpatch: skip directories in file checking mode Rob Herring
2014-04-08 15:06 ` Joe Perches [this message]
2014-04-08 15:03 ` [PATCH 1/2] checkpatch: fix wildcard DT compatible string checking Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396969596.2812.9.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox