linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	David Ahern <dsahern@gmail.com>, Andi Kleen <ak@linux.intel.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCHSET 0/7] perf tools: Update on filtered entries' percentage output (v8)
Date: Fri, 11 Apr 2014 01:01:53 +0900	[thread overview]
Message-ID: <1397145720-8063-1-git-send-email-namhyung@kernel.org> (raw)

Hello,

I added --percentage option to perf report to control display of
percentage of filtered entries.

 usage: perf report [<options>]

        --percentage <relative|absolute>
                          how to display percentage of filtered entries

"relative" means it's relative to filtered entries only so that the
sum of shown entries will be always 100%.  "absolute" means it retains
original value before and after the filter applied.  In patch 9/9, I
made the "absolute" as default since it makes more sense IMHO.

      $ perf report -s comm
      # Overhead       Command
      # ........  ............
      #
          74.19%           cc1
           7.61%           gcc
           6.11%            as
           4.35%            sh
           4.14%          make
           1.13%        fixdep
      ...

      $ perf report -s comm -c cc1,gcc --percentage absolute
      # Overhead       Command
      # ........  ............
      #
          74.19%           cc1
           7.61%           gcc

      $ perf report -s comm -c cc1,gcc --percentage relative
      # Overhead       Command
      # ........  ............
      #
          90.69%           cc1
           9.31%           gcc

Note that it has zero effect if no filter was applied.

 * changes in v8:
  - don't touch irrelavant code (Arnaldo)
  - rebase to jolsa/perf/core_new

 * changes in v7:
  - rename ->nr_filtered_* to ->nr_non_filtered_* (Arnaldo)
  - remove an unneeded alignment change (Arnaldo)

 * changes in v6:
  - fix a bug in --stdio group report
  - reuse __hpp__fmt() function in TUI/GTK
  - add Acked-by from Jiri

 * changes in v5:
  - fix 0 samples in relative percent output (Jiri)
  - factor hists__total_period function (Jiri)
  - share config parsing code with option parser (Jiri)

 * changes in v4:
  - support perf top and perf diff also  (Jiri)
  - add HIST_FILTER__HOST/GUEST  (Jiri)
  - retain both of filtered and total stats  (Arnaldo)
  - add 'F' hotkey on TUI  (Jiri)
  - rename config variable to have "hist." prefix


You can get this on the 'perf/percentage-v8' branch in my tree

  git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Any comments are welcome, thanks
Namhyung


Namhyung Kim (7):
  perf hists: Add support for showing relative percentage
  perf report: Add --percentage option
  perf top: Add --percentage option
  perf diff: Add --percentage option
  perf tools: Add hist.percentage config option
  perf ui/tui: Add 'F' hotkey to toggle percentage output
  perf tools: Show absolute percentage by default

 tools/perf/Documentation/perf-diff.txt   |   21 +++++++++--
 tools/perf/Documentation/perf-report.txt |   24 +++++++++---
 tools/perf/Documentation/perf-top.txt    |   18 +++++++--
 tools/perf/builtin-diff.c                |   32 ++++++++++++----
 tools/perf/builtin-report.c              |   22 ++++++++++-
 tools/perf/builtin-top.c                 |    8 +++-
 tools/perf/ui/browsers/hists.c           |   39 ++++++++++++++++----
 tools/perf/ui/gtk/hists.c                |   11 +++---
 tools/perf/ui/hist.c                     |    8 ++--
 tools/perf/util/config.c                 |    4 ++
 tools/perf/util/hist.c                   |   59 +++++++++++++++++++++++-------
 tools/perf/util/hist.h                   |   10 +++++
 tools/perf/util/symbol.h                 |    3 +-
 13 files changed, 203 insertions(+), 56 deletions(-)

-- 
1.7.9.2


             reply	other threads:[~2014-04-10 16:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10 16:01 Namhyung Kim [this message]
2014-04-10 16:01 ` [PATCH 1/7] perf hists: Add support for showing relative percentage Namhyung Kim
2014-04-17  9:55   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-04-10 16:01 ` [PATCH 2/7] perf report: Add --percentage option Namhyung Kim
2014-04-17  9:55   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-04-10 16:01 ` [PATCH 3/7] perf top: " Namhyung Kim
2014-04-17  9:55   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-04-10 16:01 ` [PATCH 4/7] perf diff: " Namhyung Kim
2014-04-17  9:56   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-04-10 16:01 ` [PATCH 5/7] perf tools: Add hist.percentage config option Namhyung Kim
2014-04-17  9:56   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-04-10 16:01 ` [PATCH 6/7] perf ui/tui: Add 'F' hotkey to toggle percentage output Namhyung Kim
2014-04-17  9:56   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-04-10 16:02 ` [PATCH 7/7] perf tools: Show absolute percentage by default Namhyung Kim
2014-04-17  9:56   ` [tip:perf/core] " tip-bot for Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397145720-8063-1-git-send-email-namhyung@kernel.org \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).