public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: minyard@acm.org
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	OpenIPMI Developers <openipmi-developer@lists.sourceforge.net>,
	Corey Minyard <cminyard@mvista.com>
Subject: [PATCH 3/7] ipmi: Reset the KCS timeout when starting error recovery
Date: Mon, 14 Apr 2014 09:46:52 -0500	[thread overview]
Message-ID: <1397486816-18045-4-git-send-email-minyard@acm.org> (raw)
In-Reply-To: <1397486816-18045-1-git-send-email-minyard@acm.org>

From: Corey Minyard <cminyard@mvista.com>

The OBF timer in KCS was not reset in one situation when error
recovery was started, resulting in an immediate timeout.

Reported-by: Bodo Stroesser <bstroesser@ts.fujitsu.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
---
 drivers/char/ipmi/ipmi_kcs_sm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_kcs_sm.c b/drivers/char/ipmi/ipmi_kcs_sm.c
index 6a4bdc1..8c25f59 100644
--- a/drivers/char/ipmi/ipmi_kcs_sm.c
+++ b/drivers/char/ipmi/ipmi_kcs_sm.c
@@ -251,8 +251,9 @@ static inline int check_obf(struct si_sm_data *kcs, unsigned char status,
 	if (!GET_STATUS_OBF(status)) {
 		kcs->obf_timeout -= time;
 		if (kcs->obf_timeout < 0) {
-		    start_error_recovery(kcs, "OBF not ready in time");
-		    return 1;
+			kcs->obf_timeout = OBF_RETRY_TIMEOUT;
+			start_error_recovery(kcs, "OBF not ready in time");
+			return 1;
 		}
 		return 0;
 	}
-- 
1.8.3.1


  parent reply	other threads:[~2014-04-14 14:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-14 14:46 [PATCH 0/7] ipmi: a bunch of small fixes minyard
2014-04-14 14:46 ` [PATCH 1/7] Char: ipmi_bt_sm, fix infinite loop minyard
2014-04-14 14:46 ` [PATCH 2/7] ipmi: Fix a race restarting the timer minyard
2014-04-14 14:46 ` minyard [this message]
2014-04-14 14:46 ` [PATCH 4/7] ipmi: Turn off default probing of interfaces minyard
2014-04-14 14:46 ` [PATCH 5/7] ipmi: Turn off all activity on an idle ipmi interface minyard
2014-04-14 14:46 ` [PATCH 6/7] Change ACPI IPMI support to "default y" minyard
2014-04-14 14:46 ` [PATCH 7/7] ipmi: boolify some things minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397486816-18045-4-git-send-email-minyard@acm.org \
    --to=minyard@acm.org \
    --cc=cminyard@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox