From: Baoquan He <bhe@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: rjw@rjwysocki.net, lenb@kernel.org, linux-acpi@vger.kernel.org,
jiang.liu@linux.intel.com, vgoyal@redhat.com,
Baoquan He <bhe@redhat.com>
Subject: [PATCH] acpi: try to trust cpu_index from x86_cpu_to_apicid
Date: Tue, 15 Apr 2014 07:55:54 +0800 [thread overview]
Message-ID: <1397519754-10205-1-git-send-email-bhe@redhat.com> (raw)
In smp with multi cpus, when enter into kdump kernel with only 1 cpu,
a warning message is printed out:
acpi LNXCPU:0a: BIOS reported wrong ACPI id 0 for the processor
In this case kdump kernel use the same ACPI tables as 1st kernel,
means lapic information is got from MADT. The acpi_id related to
this cpu index and lapic_id may not be 0, so the code to assign
value to cpu_index is not correct in this case per cpu0_initialized.
cpu index stored in x86_cpu_to_apicid need be respected.
Now fix it in this patch per boot_cpu_physical_apicid. When cpu index
related to boot_cpu_physical_apicid is not stored in x86_cpu_to_apicid,
then we can say this is UP system running SMP kernel with no LAPIC in MADT
Signed-off-by: Baoquan He <bhe@redhat.com>
---
drivers/acpi/acpi_processor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c
index c29c2c3..1ae460c 100644
--- a/drivers/acpi/acpi_processor.c
+++ b/drivers/acpi/acpi_processor.c
@@ -267,7 +267,7 @@ static int acpi_processor_get_info(struct acpi_device *device)
pr->apic_id = apic_id;
cpu_index = acpi_map_cpuid(pr->apic_id, pr->acpi_id);
- if (!cpu0_initialized) {
+ if (!cpu0_initialized && (boot_cpu_physical_apicid == pr->apic_id)) {
cpu0_initialized = 1;
/* Handle UP system running SMP kernel, with no LAPIC in MADT */
if ((cpu_index == -1) && (num_online_cpus() == 1))
--
1.8.5.3
next reply other threads:[~2014-04-14 23:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 23:55 Baoquan He [this message]
2014-04-21 20:51 ` [PATCH] acpi: try to trust cpu_index from x86_cpu_to_apicid Rafael J. Wysocki
2014-04-23 14:40 ` Baoquan He
2014-04-28 2:19 ` Baoquan He
2014-04-30 5:55 ` [Patch v2] lapic need be checked if available when initialize acpi processor id Baoquan He
2014-04-30 6:03 ` Baoquan He
2014-04-30 20:13 ` Rafael J. Wysocki
2014-05-02 8:51 ` Baoquan He
2014-05-02 12:10 ` Rafael J. Wysocki
2014-04-30 20:11 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397519754-10205-1-git-send-email-bhe@redhat.com \
--to=bhe@redhat.com \
--cc=jiang.liu@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).