From: Paul Bolle <pebolle@tiscali.nl>
To: Jiri Kosina <trivial@kernel.org>
Cc: Martin Walch <walch.martin@web.de>,
Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [TRIVIAL] Kconfig: Remove useless "default N" lines
Date: Tue, 15 Apr 2014 10:08:34 +0200 [thread overview]
Message-ID: <1397549314.1985.7.camel@x220> (raw)
In-Reply-To: <1392122327.13064.14.camel@x220>
Jiri,
On Tue, 2014-02-11 at 13:38 +0100, Paul Bolle wrote:
> A number of Kconfig entries default to (uppercase) "N". It was clearly
> intended to use "default n". But since (lowercase) "n" is the default
> anyway, these lines might as well be removed.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
>[...]
>
> arch/arc/Kconfig | 1 -
> arch/cris/arch-v32/drivers/Kconfig | 2 --
> drivers/misc/mic/Kconfig | 2 --
> drivers/staging/android/Kconfig | 2 --
> drivers/staging/bcm/Kconfig | 1 -
> drivers/staging/frontier/Kconfig | 1 -
> drivers/staging/media/go7007/Kconfig | 3 ---
> drivers/staging/rtl8187se/Kconfig | 1 -
> drivers/staging/rtl8188eu/Kconfig | 1 -
> drivers/staging/rtl8192e/rtl8192e/Kconfig | 1 -
> drivers/staging/rtl8192u/Kconfig | 1 -
> drivers/staging/rtl8712/Kconfig | 2 --
> drivers/staging/rtl8821ae/Kconfig | 1 -
This file wasn't touched by our commit c7dcec7dd463 ("Kconfig: Remove
useless "default N" lines"). Any idea why?
> drivers/staging/usbip/Kconfig | 4 ----
> drivers/usb/core/Kconfig | 1 -
> drivers/usb/host/Kconfig | 3 ---
> 16 files changed, 27 deletions(-)
>
> [...]
>
> diff --git a/drivers/staging/rtl8821ae/Kconfig b/drivers/staging/rtl8821ae/Kconfig
> index 2aa5dac..4679fd8 100644
> --- a/drivers/staging/rtl8821ae/Kconfig
> +++ b/drivers/staging/rtl8821ae/Kconfig
> @@ -6,6 +6,5 @@ config R8821AE
> select WEXT_PRIV
> select EEPROM_93CX6
> select CRYPTO
> - default N
> ---help---
> If built as a module, it will be called r8821ae.ko.
So this "default N" statement is still present in v3.15-rc1.
Paul Bolle
prev parent reply other threads:[~2014-04-15 8:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 12:38 [PATCH] [TRIVIAL] Kconfig: Remove useless "default N" lines Paul Bolle
2014-02-11 16:00 ` Randy Dunlap
2014-02-11 16:03 ` Randy Dunlap
2014-02-11 16:26 ` Paul Bolle
2014-02-11 18:09 ` Randy Dunlap
2014-04-15 8:08 ` Paul Bolle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397549314.1985.7.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=trivial@kernel.org \
--cc=walch.martin@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox