* [PATCH] regulator: tps65217: Remove *rdev[] from struct tps65217
@ 2014-04-15 11:47 Axel Lin
2014-04-16 10:01 ` Lee Jones
2014-04-18 14:47 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2014-04-15 11:47 UTC (permalink / raw)
To: Mark Brown; +Cc: Liam Girdwood, AnilKumar Ch, Lee Jones, linux-kernel
Now this driver uses devm_regulator_register() so we don't need to save rdev
pointer to tps->rdev[i] for cleanup.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/tps65217-regulator.c | 3 ---
include/linux/mfd/tps65217.h | 1 -
2 files changed, 4 deletions(-)
diff --git a/drivers/regulator/tps65217-regulator.c b/drivers/regulator/tps65217-regulator.c
index 10b78d2..8482f6b 100644
--- a/drivers/regulator/tps65217-regulator.c
+++ b/drivers/regulator/tps65217-regulator.c
@@ -257,9 +257,6 @@ static int tps65217_regulator_probe(struct platform_device *pdev)
pdev->name);
return PTR_ERR(rdev);
}
-
- /* Save regulator for cleanup */
- tps->rdev[i] = rdev;
}
return 0;
}
diff --git a/include/linux/mfd/tps65217.h b/include/linux/mfd/tps65217.h
index 54b5458..95d6938 100644
--- a/include/linux/mfd/tps65217.h
+++ b/include/linux/mfd/tps65217.h
@@ -254,7 +254,6 @@ struct tps65217 {
struct tps65217_board *pdata;
unsigned long id;
struct regulator_desc desc[TPS65217_NUM_REGULATOR];
- struct regulator_dev *rdev[TPS65217_NUM_REGULATOR];
struct regmap *regmap;
};
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: tps65217: Remove *rdev[] from struct tps65217
2014-04-15 11:47 [PATCH] regulator: tps65217: Remove *rdev[] from struct tps65217 Axel Lin
@ 2014-04-16 10:01 ` Lee Jones
2014-04-18 14:47 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2014-04-16 10:01 UTC (permalink / raw)
To: Axel Lin; +Cc: Mark Brown, Liam Girdwood, AnilKumar Ch, linux-kernel
> Now this driver uses devm_regulator_register() so we don't need to save rdev
> pointer to tps->rdev[i] for cleanup.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/tps65217-regulator.c | 3 ---
> include/linux/mfd/tps65217.h | 1 -
> 2 files changed, 4 deletions(-)
For the MFD part:
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: tps65217: Remove *rdev[] from struct tps65217
2014-04-15 11:47 [PATCH] regulator: tps65217: Remove *rdev[] from struct tps65217 Axel Lin
2014-04-16 10:01 ` Lee Jones
@ 2014-04-18 14:47 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-04-18 14:47 UTC (permalink / raw)
To: Axel Lin; +Cc: Liam Girdwood, AnilKumar Ch, Lee Jones, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 194 bytes --]
On Tue, Apr 15, 2014 at 07:47:38PM +0800, Axel Lin wrote:
> Now this driver uses devm_regulator_register() so we don't need to save rdev
> pointer to tps->rdev[i] for cleanup.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-18 14:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-15 11:47 [PATCH] regulator: tps65217: Remove *rdev[] from struct tps65217 Axel Lin
2014-04-16 10:01 ` Lee Jones
2014-04-18 14:47 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox