From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Fabian Frederick <fabf@skynet.be>,
linux-kernel <linux-kernel@vger.kernel.org>,
hch <hch@infradead.org>
Subject: Re: [PATCH 1/1] fs/xfs/xfs_log.c: Fix comparison to bool
Date: Wed, 16 Apr 2014 15:47:56 -0700 [thread overview]
Message-ID: <1397688476.3105.13.camel@joe-AO725> (raw)
In-Reply-To: <20140416151557.ac032e9621027faa8fc7f86d@linux-foundation.org>
On Wed, 2014-04-16 at 15:15 -0700, Andrew Morton wrote:
> On Sun, 13 Apr 2014 22:09:17 +0200 Fabian Frederick <fabf@skynet.be> wrote:
> > Fixing coccinelle warning
[]
> > @@ -2376,7 +2376,7 @@ next_lv:
[]
> > - if (record_cnt == 0 && ordered == false) {
> > + if (record_cnt == 0 && !ordered) {
[]
> There was nothing wrong with that code. I suspect coccinelle bustage.
Not really.
It's more a conceit that consistent uses of direct
boolean variable tests are less likely to be error
prone than variable comparisons to boolean literals.
Many style guides, CodingStyle not included, suggest
avoiding comparisons to boolean literals.
There is a checkpatch --strict message when comparing
a literal true/false.
I tend not to change these unless there are multiple
styles in the same subsystem/file.
next prev parent reply other threads:[~2014-04-16 22:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-13 20:09 [PATCH 1/1] fs/xfs/xfs_log.c: Fix comparison to bool Fabian Frederick
2014-04-16 22:15 ` Andrew Morton
2014-04-16 22:47 ` Joe Perches [this message]
2014-04-23 1:58 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397688476.3105.13.camel@joe-AO725 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox