linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Anton Vorontsov <anton@enomsg.org>
Cc: Olof Johansson <olof@lixom.net>,
	Sachin Kamat <sachin.kamat@linaro.org>,
	ajaykumar.rs@samsung.com, linux-samsung-soc@vger.kernel.org,
	Doug Anderson <dianders@chromium.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 1/5] mfd: tps65090: Don't tell child devices we have an IRQ if we don't
Date: Wed, 16 Apr 2014 16:12:25 -0700	[thread overview]
Message-ID: <1397689950-1568-2-git-send-email-dianders@chromium.org> (raw)
In-Reply-To: <1397689950-1568-1-git-send-email-dianders@chromium.org>

If we weren't given an interrupt we shouldn't tell child devices (like
the tps65090 charger) that they have an interrupt.  This is needed so
that we can support polling mode in the tps65090 charger driver.

See also (charger: tps65090: Allow charger module to be used when no
irq).

Signed-off-by: Doug Anderson <dianders@chromium.org>
Acked-by: Lee Jones <lee.jones@linaro.org>
---
Changes in v3: None
Changes in v2:
- Split noirq (polling mode) changes into MFD and charger

 drivers/mfd/tps65090.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/tps65090.c b/drivers/mfd/tps65090.c
index ba1a25d..c3cddb4 100644
--- a/drivers/mfd/tps65090.c
+++ b/drivers/mfd/tps65090.c
@@ -64,11 +64,16 @@ static struct resource charger_resources[] = {
 	}
 };
 
-static const struct mfd_cell tps65090s[] = {
-	{
+enum tps65090_cells {
+	PMIC = 0,
+	CHARGER = 1,
+};
+
+static struct mfd_cell tps65090s[] = {
+	[PMIC] = {
 		.name = "tps65090-pmic",
 	},
-	{
+	[CHARGER] = {
 		.name = "tps65090-charger",
 		.num_resources = ARRAY_SIZE(charger_resources),
 		.resources = &charger_resources[0],
@@ -211,6 +216,9 @@ static int tps65090_i2c_probe(struct i2c_client *client,
 					"IRQ init failed with err: %d\n", ret);
 			return ret;
 		}
+	} else {
+		/* Don't tell children they have an IRQ that'll never fire */
+		tps65090s[CHARGER].num_resources = 0;
 	}
 
 	ret = mfd_add_devices(tps65090->dev, -1, tps65090s,
-- 
1.9.1.423.g4596e3a


  reply	other threads:[~2014-04-16 23:16 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-16 23:12 [PATCH v3 0/5] Fixes for tps65090 for Samsung ARM Chromebook Doug Anderson
2014-04-16 23:12 ` Doug Anderson [this message]
2014-04-23 11:49   ` [PATCH v3 1/5] mfd: tps65090: Don't tell child devices we have an IRQ if we don't Lee Jones
2014-04-16 23:12 ` [PATCH v3 2/5] charger: tps65090: Allow charger module to be used when no irq Doug Anderson
2014-04-16 23:12 ` [PATCH v3 3/5] mfd: tps65090: Stop caching most registers Doug Anderson
2014-04-17 11:00   ` Lee Jones
2014-04-17 15:51     ` Doug Anderson
2014-04-23 11:27   ` Lee Jones
2014-04-23 11:50   ` Lee Jones
2014-04-16 23:12 ` [PATCH v3 4/5] regulator: tps65090: Allow setting the overcurrent wait time Doug Anderson
2014-04-18 15:06   ` Mark Brown
2014-04-23 11:51   ` Lee Jones
2014-04-23 15:48     ` Doug Anderson
2014-05-01 18:17       ` Olof Johansson
2014-05-01 18:49         ` Mark Brown
2014-05-01 18:52           ` Doug Anderson
2014-05-01 19:05             ` Mark Brown
2014-04-16 23:12 ` [PATCH v3 5/5] regulator: tps65090: Make FETs more reliable by adding retries Doug Anderson
2014-04-18 17:43   ` Mark Brown
2014-04-18 18:05     ` Doug Anderson
2014-04-22  7:47       ` Lee Jones
2014-04-22 11:02         ` Mark Brown
2014-04-22 15:07           ` Lee Jones
2014-04-22 15:28             ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397689950-1568-2-git-send-email-dianders@chromium.org \
    --to=dianders@chromium.org \
    --cc=ajaykumar.rs@samsung.com \
    --cc=anton@enomsg.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=sachin.kamat@linaro.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).