From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH 3/3] perf top/tui: Update nr_entries properly after filter is applied
Date: Thu, 17 Apr 2014 22:52:32 +0900 [thread overview]
Message-ID: <1397742752.1731.30.camel@leonhard> (raw)
In-Reply-To: <20140417131220.GB19339@krava.brq.redhat.com>
2014-04-17 (목), 15:12 +0200, Jiri Olsa:
> On Thu, Apr 17, 2014 at 04:53:26PM +0900, Namhyung Kim wrote:
> > The hist_browser__reset() is only called right after a filter is
> > applied so it needs to update browser->nr_entries properly. We cannot
> > use hists->nr_non_filtered_entries directly since it's possible that
> > such entries are also filtered out by minimum percentage.
> >
> > In addition when a filter is used for perf top, hist browser's
> > nr_entries field was not updated after applying the filter. But it
> > needs to be updated as new samples are coming.
> >
> > Rename ->nr_pcnt_entries and hist_browser__update_pcnt_entries() to
> > ->nr_filtered_entries and hist_browser__update_nr_entries() since it's
> > now used for filtered entries as well.
>
> Could you please split out that rename into separate patch?
Will do (with browser__has_filter() change).
Thanks,
Namhyung
next prev parent reply other threads:[~2014-04-17 13:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 7:53 [PATCH 0/3] perf top/tui: Fixes for percentage filter behavior Namhyung Kim
2014-04-17 7:53 ` [PATCH 1/3] perf hists: Add missing updates on nr_non_filtered_entries Namhyung Kim
2014-04-17 13:10 ` Jiri Olsa
2014-04-17 13:50 ` Namhyung Kim
2014-04-17 7:53 ` [PATCH 2/3] perf ui/tui: Fix off-by-one in hist_browser__update_nr_entries() Namhyung Kim
2014-04-17 7:53 ` [PATCH 3/3] perf top/tui: Update nr_entries properly after filter is applied Namhyung Kim
2014-04-17 13:10 ` Jiri Olsa
2014-04-17 13:12 ` Jiri Olsa
2014-04-17 13:52 ` Namhyung Kim [this message]
2014-04-17 12:00 ` [PATCH 0/3] perf top/tui: Fixes for percentage filter behavior Jiri Olsa
2014-04-17 13:38 ` Namhyung Kim
2014-04-17 18:52 ` Jiri Olsa
2014-04-18 6:55 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397742752.1731.30.camel@leonhard \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox