From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756369AbbCCL3I (ORCPT ); Tue, 3 Mar 2015 06:29:08 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:31280 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756278AbbCCL3B (ORCPT ); Tue, 3 Mar 2015 06:29:01 -0500 X-AuditID: cbfee61a-f79c06d000004e71-75-54f59afbb2c9 From: Bartlomiej Zolnierkiewicz To: Kukjin Kim Cc: linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Kyungmin Park , stable@vger.kernel.org, Marek Szyprowski Subject: Re: [RESEND PATCH] ARM: EXYNOS: Fix failed second suspend on Exynos4 Date: Tue, 03 Mar 2015 12:28:17 +0100 Message-id: <13977718.vr52PylqCh@amdc1032> User-Agent: KMail/4.8.4 (Linux/3.2.0-70-generic-pae; KDE/4.8.5; i686; ; ) In-reply-to: <2802418.zt8CxNGGkT@amdc1032> References: <1424256325-16659-1-git-send-email-k.kozlowski@samsung.com> <2802418.zt8CxNGGkT@amdc1032> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsVy+t9jQd3fs76GGJz8LG/x+oWhRf/j18wW Z5vesFtsenyN1eLyrjlsFjPO72OyWHvkLrvFgo2PGB04PDat6mTz2Lyk3qNvyypGj8+b5AJY orhsUlJzMstSi/TtErgy2u8uZCv4w1fRenQfWwNjI08XIyeHhICJxK+Zv9khbDGJC/fWs3Ux cnEICUxnlLj08xAThNPCJDFr9USwKjYBK4mJ7asYuxg5OEQEFCU2L1AACTMLTGCSmL7FAMQW FvCVeHKrmQWkhEVAVeLFnQKQMK+AlsSl381MILaogKfEzukHGEFsTqD4t5kPWUBsIYF0idbb /SwQ9YISPybfY4EYLy+xb/9UVghbS2L9zuNMExgFZiEpm4WkbBaSsgWMzKsYRVMLkguKk9Jz DfWKE3OLS/PS9ZLzczcxgsP7mdQOxpUNFocYBTgYlXh4X3B+DRFiTSwrrsw9xCjBwawkwnt+ ClCINyWxsiq1KD++qDQntfgQozQHi5I4r5J9WwjQ1YklqdmpqQWpRTBZJg5OqQbG2ZcmJloF ashcD4mbrsR7fs43CVuWyFPClxKnZ2y/dqXvP+Oa576Fn+Q/99cGuk2s+v3iQWfqM47emZrK BrWG6ronjt7czpfmMUVIu+hbw42aN0/iOLvcPZ/MZ+Cbmyf/RelllazGllM5O0JUH0u92tqv 2LTWMyla7cVp4yAtw/NP7iQ8ddulxFKckWioxVxUnAgAVujg62sCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kukjin, It has been a month since this regression fix was originally posted: https://lkml.org/lkml/2015/2/3/481 Could you please review/apply it? Thank you. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics On Monday, February 23, 2015 05:25:48 PM Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Wednesday, February 18, 2015 11:45:25 AM Krzysztof Kozlowski wrote: > > On Exynos4412 boards (Trats2, Odroid U3) after enabling L2 cache in > > 56b60b8bce4a ("ARM: 8265/1: dts: exynos4: Add nodes for L2 cache > > controller") the second suspend to RAM failed. First suspend worked fine > > but the next one hang just after powering down of secondary CPUs (system > > consumed energy as it would be running but was not responsive). > > > > The issue was caused by enabling delayed reset assertion for CPU0 just > > after issuing power down of cores. This was introduced for Exynos4 in > > 13cfa6c4f7fa ("ARM: EXYNOS: Fix CPU idle clock down after CPU off"). > > > > The whole behavior is not well documented but after checking with vendor > > code this should be done like this (on Exynos4): > > 1. Enable delayed reset assertion when system is running (for all CPUs). > > 2. Disable delayed reset assertion before suspending the system. > > This can be done after powering off secondary CPUs. > > 3. Re-enable the delayed reset assertion when system is resumed. > > > > Signed-off-by: Krzysztof Kozlowski > > Fixes: 13cfa6c4f7fa ("ARM: EXYNOS: Fix CPU idle clock down after CPU off") > > Cc: > > It turned out that this patch is also needed to fix cpuidle AFTR mode > hang on Trats2. > > Tested-by: Bartlomiej Zolnierkiewicz > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics