The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Thor Thayer <tthayer@altera.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: <robherring2@gmail.com>, <pawel.moll@arm.com>,
	<mark.rutland@arm.com>, <ijc+devicetree@hellion.org>,
	<galak@codeaurora.org>, <rob@landley.net>,
	<linux@arm.linux.org.uk>, <dinguyen@altera.com>,
	<dougthompson@xmission.com>, <grant.likely@linaro.org>,
	<tthayer.linux@gmail.com>, Borislav Petkov <bp@alien8.de>,
	<devicetree@vger.kernel.org>, <linux-edac@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2 3/3] edac: altera: Add SDRAM EDAC support for CycloneV/ArriaV
Date: Mon, 21 Apr 2014 16:33:41 -0500	[thread overview]
Message-ID: <1398116021.12716.1.camel@dinh-ubuntu> (raw)
In-Reply-To: <20140421102750.GA27209@amd.pavel.ucw.cz>

On Mon, 2014-04-21 at 12:27 +0200, Pavel Machek wrote:
> Hi!
> 
> > From: Thor Thayer <tthayer@altera.com>
> > 
> > Added EDAC support for reporting ECC errors of CycloneV
> > and ArriaV SDRAM controller.
> > - The SDRAM Controller registers are used by the FPGA bridge so
> >   these are accessed through the syscon interface.
> > - The configuration of the SDRAM memory size for the EDAC framework
> >   is discovered from the SDRAM Controller registers.
> > - Documentation of the bindings in devicetree/bindings/arm/altera/
> >   socfpga-sdram-edac.txt
> > - Correction of single bit errors, detection of double bit errors.
> > 
> > ---
> > v2: Use the SDRAM controller registers to calculate memory size
> >     instead of the Device Tree. Update To & Cc list. Add maintainer 
> >     information.
> 
> I'd reduce number of *s in the messages, otherwise
> 
> Reviewed-by: Pavel Machek <pavel@ucw.cz>
> 
> for whole series.
> 								Pavel
> 
Hi Pavel.

Noted - I will make the change. Thank you for reviewing.

Thor


  reply	other threads:[~2014-04-21 21:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1397604610-20931-1-git-send-email-tthayer@altera.com>
2014-04-15 23:30 ` [PATCHv2 1/3] dts: socfpga: Add bindings for Altera SoC SDRAM controller tthayer
2014-04-15 23:30 ` [PATCHv2 2/3] dts: socfpga: Add bindings for Altera SoC SDRAM EDAC tthayer
2014-04-15 23:30 ` [PATCHv2 3/3] edac: altera: Add SDRAM EDAC support for CycloneV/ArriaV tthayer
2014-04-21 10:27   ` Pavel Machek
2014-04-21 21:33     ` Thor Thayer [this message]
2014-04-23 14:54   ` Borislav Petkov
2014-04-24 14:08     ` Thor Thayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398116021.12716.1.camel@dinh-ubuntu \
    --to=tthayer@altera.com \
    --cc=bp@alien8.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@altera.com \
    --cc=dougthompson@xmission.com \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@linaro.org \
    --cc=ijc+devicetree@hellion.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pavel@ucw.cz \
    --cc=pawel.moll@arm.com \
    --cc=rob@landley.net \
    --cc=robherring2@gmail.com \
    --cc=tthayer.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox