public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jianyu Zhan <nasa4836@gmail.com>
To: tj@kernel.org, lizefan@huawei.com
Cc: containers@lists.linux-foundation.org, cgroups@vger.kernel.org,
	linux-kernel@vger.kernel.org, nasa4836@gmail.com
Subject: [PATCH] cgroup: use uninitialized_var() for may-be uninitialized variable
Date: Tue, 22 Apr 2014 13:44:39 +0800	[thread overview]
Message-ID: <1398145479-11400-1-git-send-email-nasa4836@gmail.com> (raw)

To suppress this warning:

 warning: ‘err’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  int err;
	^

Use the uninitialized_var() to decalre err. It also serves to be good documetation.

Signed-off-by: Jianyu Zhan <nasa4836@gmail.com>
---
 kernel/cgroup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 24675f5..930569c 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -4144,7 +4144,7 @@ static int create_css(struct cgroup *cgrp, struct cgroup_subsys *ss)
 {
 	struct cgroup *parent = cgrp->parent;
 	struct cgroup_subsys_state *css;
-	int err;
+	int uninitialized_var(err);
 
 	lockdep_assert_held(&cgroup_mutex);
 
-- 
2.0.0-rc0


             reply	other threads:[~2014-04-22  5:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22  5:44 Jianyu Zhan [this message]
2014-04-22  6:26 ` [PATCH] cgroup: use uninitialized_var() for may-be uninitialized variable Li Zefan
2014-04-22  7:52   ` Jianyu Zhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398145479-11400-1-git-send-email-nasa4836@gmail.com \
    --to=nasa4836@gmail.com \
    --cc=cgroups@vger.kernel.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox