From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH 04/11] perf hists: Add a couple of hists stat helper functions
Date: Thu, 24 Apr 2014 22:46:43 +0900 [thread overview]
Message-ID: <1398347203.1681.22.camel@leonhard> (raw)
In-Reply-To: <20140424131209.GF1110@krava.brq.redhat.com>
2014-04-24 (목), 15:12 +0200, Jiri Olsa:
> On Thu, Apr 24, 2014 at 09:57:46PM +0900, Namhyung Kim wrote:
> > 2014-04-24 (목), 11:40 +0200, Jiri Olsa:
> > > maybe I'm missing some case, but why is not 'nr_non_filtered_samples'
> > > reset/increased in hists__reset_filter_stats/hists__inc_filter_stats functions?
> >
> > Because basically number of sample is counted at input stage, and these
> > functions are called at output stage. But if a new filter is applied,
> > we need to re-count the numbers for the filter so it needs to be counted
> > separately.
>
> ok.. I'll queue this for perf/core
Thank you so much!
Namhyung
next prev parent reply other threads:[~2014-04-24 13:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 8:23 [PATCHSET 00/11] perf tools: Fixup for the --percentage change (v3) Namhyung Kim
2014-04-24 8:23 ` [PATCH 01/11] perf report: Count number of entries separately Namhyung Kim
2014-04-25 13:13 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-04-24 8:23 ` [PATCH 02/11] perf hists: Rename hists__inc_stats() Namhyung Kim
2014-04-25 13:13 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-04-24 8:23 ` [PATCH 03/11] perf hists: Move column length calculation out of hists__inc_stats() Namhyung Kim
2014-04-25 13:13 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-04-24 8:23 ` [PATCH 04/11] perf hists: Add a couple of hists stat helper functions Namhyung Kim
2014-04-24 9:40 ` Jiri Olsa
2014-04-24 12:57 ` Namhyung Kim
2014-04-24 13:12 ` Jiri Olsa
2014-04-24 13:46 ` Namhyung Kim [this message]
2014-04-25 13:13 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-04-24 8:23 ` [PATCH 05/11] perf hists: Collapse expanded callchains after filter is applied Namhyung Kim
2014-04-25 13:14 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-04-24 8:23 ` [PATCH 06/11] perf tools: Account entry stats when it's added to the output tree Namhyung Kim
2014-04-25 13:14 ` [tip:perf/core] perf tools: Account entry stats when it' s " tip-bot for Namhyung Kim
2014-04-24 8:23 ` [PATCH 07/11] perf hists: Add missing update on filtered stats in hists__decay_entries() Namhyung Kim
2014-04-25 13:14 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-04-24 8:24 ` [PATCH 08/11] perf ui/tui: Fix off-by-one in hist_browser__update_nr_entries() Namhyung Kim
2014-04-25 13:14 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-04-24 8:24 ` [PATCH 09/11] perf ui/tui: Rename hist_browser__update_nr_entries() Namhyung Kim
2014-04-25 13:14 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-04-24 8:24 ` [PATCH 10/11] perf top/tui: Update nr_entries properly after a filter is applied Namhyung Kim
2014-04-25 13:15 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-04-24 8:24 ` [PATCH 11/11] perf hists/tui: Count callchain rows separately Namhyung Kim
2014-04-25 13:15 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-04-24 11:34 ` [PATCHSET 00/11] perf tools: Fixup for the --percentage change (v3) Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2014-04-24 15:40 [GIT PULL 00/11] perf/core improvements and fixes Jiri Olsa
2014-04-24 15:40 ` [PATCH 04/11] perf hists: Add a couple of hists stat helper functions Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398347203.1681.22.camel@leonhard \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).