From: Dinh Nguyen <dinguyen@altera.com>
To: ZY - pavel <pavel@denx.de>, <mturquette@linaro.org>
Cc: <dinh.linux@gmail.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] clk: socfpga: fix clock driver for 3.15
Date: Thu, 24 Apr 2014 17:47:49 -0500 [thread overview]
Message-ID: <1398379669.14881.2.camel@linux-builds1> (raw)
In-Reply-To: <20140424152133.GA23032@amd.pavel.ucw.cz>
Hi Mike,
On Thu, 2014-04-24 at 17:21 +0200, ZY - pavel wrote:
> Hi!
>
> > commit [1771b10d6 clk: respect the clock dependencies in of_clk_init]
> > exposed a flaw in the socfpga clock driver and prevents the platform
> > from booting on 3.15-rc1.
> >
> > Because the "altr,clk-mgr" is not really a clock, it should not be using
> > CLK_OF_DECLARE, instead we should be mapping the clk-mgr's base address
> > one of the functional clock init function. Use the socfpga_pll_init function
> > to map the clk_mgr_base_addr as this clock should always be initialized first.
> >
> > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
>
> Works for me, thanks!
> Pavel
>
> Tested-by: Pavel Machek <pavel@denx.de>
>
I'm hoping you can queued this up for one of the 3.15-rc.
Thanks,
Dinh
next prev parent reply other threads:[~2014-04-24 22:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 13:15 [PATCH] clk: socfpga: fix clock driver for 3.15 dinguyen
2014-04-24 15:21 ` Pavel Machek
2014-04-24 22:47 ` Dinh Nguyen [this message]
2014-04-30 19:19 ` Mike Turquette
2014-04-30 19:24 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398379669.14881.2.camel@linux-builds1 \
--to=dinguyen@altera.com \
--cc=dinh.linux@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=pavel@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox