Re: [PATCH v7 1/2] serial: sc16is7xx

["Alexander Shiyan" <shc_work@mail.ru>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 1842 bytes --]

Fri, 25 Apr 2014 10:26:40 -0700 от Greg KH <gregkh@linuxfoundation.org>:
> On Thu, Apr 24, 2014 at 08:56:06PM -0400, jon@ringle.org wrote:
> > From: Jon Ringle <jringle@gridpoint.com>
> > 
> > The SC16IS7xx is a slave I2C-bus/SPI interface to a single-channel
> > high performance UART. The SC16IS7xx's internal register set is
> > backward-compatible with the widely used and widely popular 16C450.
> > 
> > The SC16IS7xx also provides additional advanced features such as
> > auto hardware and software flow control, automatic RS-485 support, and
> > software reset.
> > 
> > Signed-off-by: Jon Ringle <jringle@gridpoint.com>
> > ---
> >  drivers/tty/serial/Kconfig       |    9 +
> >  drivers/tty/serial/Makefile      |    1 +
> >  drivers/tty/serial/sc16is7xx.c   | 1279 ++++++++++++++++++++++++++++++++++++++
> >  include/uapi/linux/serial_core.h |    3 +
> >  4 files changed, 1292 insertions(+)
> >  create mode 100644 drivers/tty/serial/sc16is7xx.c
> 
> I get a few build warnings with this patch applied:
> 
> drivers/tty/serial/sc16is7xx.c:1059:12: warning: ‘sc16is7xx_probe’ defined but not used [-Wunused-function]
>  static int sc16is7xx_probe(struct device *dev,
>             ^
> drivers/tty/serial/sc16is7xx.c:1175:12: warning: ‘sc16is7xx_remove’ defined but not used [-Wunused-function]
>  static int sc16is7xx_remove(struct device *dev)
>             ^
> drivers/tty/serial/sc16is7xx.c:1214:29: warning: ‘regcfg’ defined but not used [-Wunused-variable]
>  static struct regmap_config regcfg = {
>                              ^
> 
> Can you send a follow-on patch to fix them?

Seems this just should contain: "depends on I2C" in the Kconfig.

---

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥