Re: [PATCH 1/2] serial: sc16is7xx: depend on I2C

["Alexander Shiyan" <shc_work@mail.ru>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 1405 bytes --]

Fri, 25 Apr 2014 13:35:28 -0700 от Greg KH <gregkh@linuxfoundation.org>:
> On Sat, Apr 26, 2014 at 12:26:16AM +0400, Alexander Shiyan wrote:
> > Fri, 25 Apr 2014 13:23:15 -0700 от Greg KH <gregkh@linuxfoundation.org>:
> > > On Fri, Apr 25, 2014 at 03:53:09PM -0400, jon@ringle.org wrote:
> > > > From: Jon Ringle <jringle@gridpoint.com>
> > > > 
> > > > Signed-off-by: Jon Ringle <jringle@gridpoint.com>
> > > > ---
> > > >  drivers/tty/serial/Kconfig | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> > > > index c3e2b32..64c5659 100644
> > > > --- a/drivers/tty/serial/Kconfig
> > > > +++ b/drivers/tty/serial/Kconfig
> > > > @@ -1180,6 +1180,7 @@ config SERIAL_SCCNXP_CONSOLE
> > > >  
> > > >  config SERIAL_SC16IS7XX
> > > >  	tristate "SC16IS7xx serial support"
> > > > +	depends on I2C
> > > >  	select SERIAL_CORE
> > > >  	select REGMAP_I2C if I2C
> > > >  	help
> > > > -- 
> > > > 1.8.5.4
> > > 
> > > Better, but I still have the build warnings :(
> > 
> > I hope not same as before?
> 
> Exactly the same.

Hmm...

In the source:
#ifdef CONFIG_REGMAP_I2C
Should be of course #ifdef CONFIG_I2C
But this should not provide such warnings...

---

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥