From: Oleg Drokin <green@linuxhacker.ru>
To: linux-kernel@vger.kernel.org
Cc: Oleg Drokin <green@linuxhacker.ru>,
Oleg Drokin <oleg.drokin@intel.com>,
Dmitry Eremin <dmitry.eremin@intel.com>,
Liang Zhen <liang.zhen@intel.com>
Subject: [PATCH v2 4/4] staging/lustre/lnet: fix potential null pointer dereference
Date: Sun, 27 Apr 2014 22:00:49 -0400 [thread overview]
Message-ID: <1398650449-4587-5-git-send-email-green@linuxhacker.ru> (raw)
In-Reply-To: <1398650449-4587-1-git-send-email-green@linuxhacker.ru>
Pointer 'ni' checked for NULL at line 1569 may be passed to
function and may be dereferenced there by passing argument 1 to
function 'lnet_ni_notify_locked' at line 1621.
found by Klocwork Insight tool
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
CC: Dmitry Eremin <dmitry.eremin@intel.com>
CC: Liang Zhen <liang.zhen@intel.com>
---
drivers/staging/lustre/lnet/lnet/router.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/lnet/router.c b/drivers/staging/lustre/lnet/lnet/router.c
index 995f509..926923a 100644
--- a/drivers/staging/lustre/lnet/lnet/router.c
+++ b/drivers/staging/lustre/lnet/lnet/router.c
@@ -145,7 +145,7 @@ lnet_ni_notify_locked(lnet_ni_t *ni, lnet_peer_t *lp)
* NB individual events can be missed; the only guarantee is that you
* always get the most recent news */
- if (lp->lp_notifying)
+ if (lp->lp_notifying || ni == NULL)
return;
lp->lp_notifying = 1;
--
1.9.0
prev parent reply other threads:[~2014-04-28 2:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 2:00 [PATCH v2 0/4] Lustre Klocwork fixes Oleg Drokin
2014-04-28 2:00 ` [PATCH v2 1/4] staging/lustre/lnet: Drop useless LASSERT in ksocknal_select_ips Oleg Drokin
2014-04-28 2:00 ` [PATCH v2 2/4] staging/lustre/lnet: remove unused variable in lnet_destroy_remote_nets_table Oleg Drokin
2014-04-28 2:00 ` [PATCH v2 3/4] staging/lustre/lnet: fix potential null pointer dereference in kiblnd_rejected Oleg Drokin
2014-04-28 2:00 ` Oleg Drokin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398650449-4587-5-git-send-email-green@linuxhacker.ru \
--to=green@linuxhacker.ru \
--cc=dmitry.eremin@intel.com \
--cc=liang.zhen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).