Re: [PATCHv2 7/9] ASoC: omap: rx51: Add some error messages

Pavel Machek
2014-06-30T10:02:45Z

Hi!

> Add more error messages making it easier to identify problems.
>
> Signed-off-by: Sebastian Reichel <sre@kernel.org>
> ---
> sound/soc/omap/rx51.c | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)

> + if (err) {
> + dev_err(card->dev, "Failed to add GPIOs\n");
> + return err;
> + }
>
> return err;
> }

As you'll return err, anyway, you don't need to do it inside the if()... OTOH it
does not hurt.

Acked-by: Pavel Machek <pavel@ucw.cz>

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html