From: navin patidar <navin.patidar@gmail.com>
To: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
navin patidar <navin.patidar@gmail.com>
Subject: [PATCH 09/15] staging: rtl8188eu: Remove 'irp_pending' from struct recv_buf
Date: Sat, 3 May 2014 17:15:26 +0530 [thread overview]
Message-ID: <1399117532-8521-10-git-send-email-navin.patidar@gmail.com> (raw)
In-Reply-To: <1399117532-8521-1-git-send-email-navin.patidar@gmail.com>
irp_pending is initialized to false inside rtw_os_recvbuf_resource_alloc()
and value of irq_pending never changed after that, so 'if (!precvbuf->irp_pending)'
inside rtw_os_read_port() function will be always true.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 1 -
drivers/staging/rtl8188eu/os_dep/recv_linux.c | 6 ++----
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h
index 8d3424b..987445a 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -242,7 +242,6 @@ struct recv_buf {
u32 len;
struct urb *purb;
u32 alloc_sz;
- u8 irp_pending;
struct sk_buff *pskb;
u8 reuse;
};
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
index 99b5910..7f9b654 100644
--- a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
@@ -55,7 +55,6 @@ int rtw_os_recvbuf_resource_alloc(struct adapter *padapter,
{
int res = _SUCCESS;
- precvbuf->irp_pending = false;
precvbuf->purb = usb_alloc_urb(0, GFP_KERNEL);
if (precvbuf->purb == NULL)
res = _FAIL;
@@ -229,9 +228,8 @@ void rtw_os_read_port(struct adapter *padapter, struct recv_buf *precvbuf)
dev_kfree_skb_any(precvbuf->pskb);
precvbuf->pskb = NULL;
precvbuf->reuse = false;
- if (!precvbuf->irp_pending)
- rtw_read_port(padapter, precvpriv->ff_hwaddr, 0,
- (unsigned char *)precvbuf);
+ rtw_read_port(padapter, precvpriv->ff_hwaddr, 0,
+ (unsigned char *)precvbuf);
}
static void _rtw_reordering_ctrl_timeout_handler(void *func_context)
--
1.7.10.4
next prev parent reply other threads:[~2014-05-03 11:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-03 11:45 [PATCH 00/15] staging: rtl8188eu: clean-up struct recv_buf navin patidar
2014-05-03 11:45 ` [PATCH 01/15] staging: rtl8188eu: Remove function rtw_dequeue_recvbuf() navin patidar
2014-05-03 11:45 ` [PATCH 02/15] staging: rtl8188eu: Remove function rtw_enqueue_recvbuf_to_head() navin patidar
2014-05-03 11:45 ` [PATCH 03/15] staging: rtl8188eu: Remove function rtw_enqueue_recvbuf() navin patidar
2014-05-03 11:45 ` [PATCH 04/15] staging: rtl8188eu: Remove 'struct list_head list' from struct recv_buf navin patidar
2014-05-03 11:45 ` [PATCH 05/15] staging: rtl8188eu: Remove 'spinlock_t recvbuf_lock' " navin patidar
2014-05-03 11:45 ` [PATCH 06/15] staging: rtl8188eu: Remove 'dma_addr_t dma_transfer_addr' " navin patidar
2014-05-03 11:45 ` [PATCH 07/15] staging: rtl8188eu: Remove 'int transfer_len' " navin patidar
2014-05-03 11:45 ` [PATCH 08/15] staging: rtl8188eu: Remove pdata, phead, ptail and pend " navin patidar
2014-05-03 11:45 ` navin patidar [this message]
2014-05-03 11:45 ` [PATCH 10/15] staging: rtl8188eu: Remove 'pallocated_buf' " navin patidar
2014-05-03 11:45 ` [PATCH 11/15] staging: rtl8188eu: Remove 'alloc_sz' " navin patidar
2014-05-03 11:45 ` [PATCH 12/15] staging: rtl8188eu: Remove 'u32 len' " navin patidar
2014-05-03 11:45 ` [PATCH 13/15] staging: rtl8188eu: Remove 'u32 ref_cnt' " navin patidar
2014-05-03 11:45 ` [PATCH 14/15] staging: rtl8188eu: Remove rtl8188eu_init_recvbuf() function navin patidar
2014-05-03 11:45 ` [PATCH 15/15] staging: rtl8188eu: Remove 'u8 *pbuf' from struct recv_buf navin patidar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399117532-8521-10-git-send-email-navin.patidar@gmail.com \
--to=navin.patidar@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).