From: navin patidar <navin.patidar@gmail.com>
To: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
navin patidar <navin.patidar@gmail.com>
Subject: [PATCH 15/15] staging: rtl8188eu: Remove 'u8 *pbuf' from struct recv_buf
Date: Sat, 3 May 2014 17:15:32 +0530 [thread overview]
Message-ID: <1399117532-8521-16-git-send-email-navin.patidar@gmail.com> (raw)
In-Reply-To: <1399117532-8521-1-git-send-email-navin.patidar@gmail.com>
Instead of using pbuf to pass sbk data pointer to usb_fill_bulk_urb(),
we can use precvbuf->pskb->data to do that.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
---
drivers/staging/rtl8188eu/hal/usb_ops_linux.c | 5 +----
drivers/staging/rtl8188eu/include/rtw_recv.h | 1 -
drivers/staging/rtl8188eu/os_dep/recv_linux.c | 1 -
3 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
index d3c5ed3..d8fc747 100644
--- a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
+++ b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
@@ -612,10 +612,7 @@ static u32 usb_read_port(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *rmem)
tmpaddr = (size_t)precvbuf->pskb->data;
alignment = tmpaddr & (RECVBUFF_ALIGN_SZ-1);
skb_reserve(precvbuf->pskb, (RECVBUFF_ALIGN_SZ - alignment));
-
- precvbuf->pbuf = precvbuf->pskb->data;
} else { /* reuse skb */
- precvbuf->pbuf = precvbuf->pskb->data;
precvbuf->reuse = false;
}
@@ -627,7 +624,7 @@ static u32 usb_read_port(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *rmem)
pipe = ffaddr2pipehdl(pdvobj, addr);
usb_fill_bulk_urb(purb, pusbd, pipe,
- precvbuf->pbuf,
+ precvbuf->pskb->data,
MAX_RECVBUF_SZ,
usb_read_port_complete,
precvbuf);/* context is precvbuf */
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h
index 8dadf30..971dd16 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -236,7 +236,6 @@ struct sta_recv_priv {
struct recv_buf {
struct adapter *adapter;
- u8 *pbuf;
struct urb *purb;
struct sk_buff *pskb;
u8 reuse;
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
index c1664b7..29ec014 100644
--- a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
@@ -60,7 +60,6 @@ int rtw_os_recvbuf_resource_alloc(struct adapter *padapter,
res = _FAIL;
precvbuf->pskb = NULL;
precvbuf->reuse = false;
- precvbuf->pbuf = NULL;
return res;
}
--
1.7.10.4
prev parent reply other threads:[~2014-05-03 11:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-03 11:45 [PATCH 00/15] staging: rtl8188eu: clean-up struct recv_buf navin patidar
2014-05-03 11:45 ` [PATCH 01/15] staging: rtl8188eu: Remove function rtw_dequeue_recvbuf() navin patidar
2014-05-03 11:45 ` [PATCH 02/15] staging: rtl8188eu: Remove function rtw_enqueue_recvbuf_to_head() navin patidar
2014-05-03 11:45 ` [PATCH 03/15] staging: rtl8188eu: Remove function rtw_enqueue_recvbuf() navin patidar
2014-05-03 11:45 ` [PATCH 04/15] staging: rtl8188eu: Remove 'struct list_head list' from struct recv_buf navin patidar
2014-05-03 11:45 ` [PATCH 05/15] staging: rtl8188eu: Remove 'spinlock_t recvbuf_lock' " navin patidar
2014-05-03 11:45 ` [PATCH 06/15] staging: rtl8188eu: Remove 'dma_addr_t dma_transfer_addr' " navin patidar
2014-05-03 11:45 ` [PATCH 07/15] staging: rtl8188eu: Remove 'int transfer_len' " navin patidar
2014-05-03 11:45 ` [PATCH 08/15] staging: rtl8188eu: Remove pdata, phead, ptail and pend " navin patidar
2014-05-03 11:45 ` [PATCH 09/15] staging: rtl8188eu: Remove 'irp_pending' " navin patidar
2014-05-03 11:45 ` [PATCH 10/15] staging: rtl8188eu: Remove 'pallocated_buf' " navin patidar
2014-05-03 11:45 ` [PATCH 11/15] staging: rtl8188eu: Remove 'alloc_sz' " navin patidar
2014-05-03 11:45 ` [PATCH 12/15] staging: rtl8188eu: Remove 'u32 len' " navin patidar
2014-05-03 11:45 ` [PATCH 13/15] staging: rtl8188eu: Remove 'u32 ref_cnt' " navin patidar
2014-05-03 11:45 ` [PATCH 14/15] staging: rtl8188eu: Remove rtl8188eu_init_recvbuf() function navin patidar
2014-05-03 11:45 ` navin patidar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399117532-8521-16-git-send-email-navin.patidar@gmail.com \
--to=navin.patidar@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).