From: navin patidar <navin.patidar@gmail.com>
To: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
navin patidar <navin.patidar@gmail.com>
Subject: [PATCH 08/15] staging: rtl8188eu: Remove pdata, phead, ptail and pend from struct recv_buf
Date: Sat, 3 May 2014 17:15:25 +0530 [thread overview]
Message-ID: <1399117532-8521-9-git-send-email-navin.patidar@gmail.com> (raw)
In-Reply-To: <1399117532-8521-1-git-send-email-navin.patidar@gmail.com>
Driver is not making use of value stored in removed variables.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
---
drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 8 --------
drivers/staging/rtl8188eu/hal/usb_ops_linux.c | 9 ---------
drivers/staging/rtl8188eu/include/rtw_recv.h | 4 ----
drivers/staging/rtl8188eu/os_dep/recv_linux.c | 4 ----
4 files changed, 25 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
index ee7fa64..41a0c0d 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c
@@ -31,15 +31,7 @@
void rtl8188eu_init_recvbuf(struct adapter *padapter, struct recv_buf *precvbuf)
{
precvbuf->len = 0;
-
precvbuf->ref_cnt = 0;
-
- if (precvbuf->pbuf) {
- precvbuf->pdata = precvbuf->pbuf;
- precvbuf->phead = precvbuf->pbuf;
- precvbuf->ptail = precvbuf->pbuf;
- precvbuf->pend = precvbuf->pdata + MAX_RECVBUF_SZ;
- }
}
int rtl8188eu_init_recv_priv(struct adapter *padapter)
diff --git a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
index 285cb5f..654c5b3 100644
--- a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
+++ b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
@@ -615,18 +615,9 @@ static u32 usb_read_port(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *rmem)
alignment = tmpaddr & (RECVBUFF_ALIGN_SZ-1);
skb_reserve(precvbuf->pskb, (RECVBUFF_ALIGN_SZ - alignment));
- precvbuf->phead = precvbuf->pskb->head;
- precvbuf->pdata = precvbuf->pskb->data;
- precvbuf->ptail = skb_tail_pointer(precvbuf->pskb);
- precvbuf->pend = skb_end_pointer(precvbuf->pskb);
precvbuf->pbuf = precvbuf->pskb->data;
} else { /* reuse skb */
- precvbuf->phead = precvbuf->pskb->head;
- precvbuf->pdata = precvbuf->pskb->data;
- precvbuf->ptail = skb_tail_pointer(precvbuf->pskb);
- precvbuf->pend = skb_end_pointer(precvbuf->pskb);
precvbuf->pbuf = precvbuf->pskb->data;
-
precvbuf->reuse = false;
}
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h
index cac8acb..8d3424b 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -240,10 +240,6 @@ struct recv_buf {
u8 *pbuf;
u8 *pallocated_buf;
u32 len;
- u8 *phead;
- u8 *pdata;
- u8 *ptail;
- u8 *pend;
struct urb *purb;
u32 alloc_sz;
u8 irp_pending;
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
index 0838339..99b5910 100644
--- a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/recv_linux.c
@@ -63,10 +63,6 @@ int rtw_os_recvbuf_resource_alloc(struct adapter *padapter,
precvbuf->reuse = false;
precvbuf->pallocated_buf = NULL;
precvbuf->pbuf = NULL;
- precvbuf->pdata = NULL;
- precvbuf->phead = NULL;
- precvbuf->ptail = NULL;
- precvbuf->pend = NULL;
precvbuf->len = 0;
return res;
}
--
1.7.10.4
next prev parent reply other threads:[~2014-05-03 11:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-03 11:45 [PATCH 00/15] staging: rtl8188eu: clean-up struct recv_buf navin patidar
2014-05-03 11:45 ` [PATCH 01/15] staging: rtl8188eu: Remove function rtw_dequeue_recvbuf() navin patidar
2014-05-03 11:45 ` [PATCH 02/15] staging: rtl8188eu: Remove function rtw_enqueue_recvbuf_to_head() navin patidar
2014-05-03 11:45 ` [PATCH 03/15] staging: rtl8188eu: Remove function rtw_enqueue_recvbuf() navin patidar
2014-05-03 11:45 ` [PATCH 04/15] staging: rtl8188eu: Remove 'struct list_head list' from struct recv_buf navin patidar
2014-05-03 11:45 ` [PATCH 05/15] staging: rtl8188eu: Remove 'spinlock_t recvbuf_lock' " navin patidar
2014-05-03 11:45 ` [PATCH 06/15] staging: rtl8188eu: Remove 'dma_addr_t dma_transfer_addr' " navin patidar
2014-05-03 11:45 ` [PATCH 07/15] staging: rtl8188eu: Remove 'int transfer_len' " navin patidar
2014-05-03 11:45 ` navin patidar [this message]
2014-05-03 11:45 ` [PATCH 09/15] staging: rtl8188eu: Remove 'irp_pending' " navin patidar
2014-05-03 11:45 ` [PATCH 10/15] staging: rtl8188eu: Remove 'pallocated_buf' " navin patidar
2014-05-03 11:45 ` [PATCH 11/15] staging: rtl8188eu: Remove 'alloc_sz' " navin patidar
2014-05-03 11:45 ` [PATCH 12/15] staging: rtl8188eu: Remove 'u32 len' " navin patidar
2014-05-03 11:45 ` [PATCH 13/15] staging: rtl8188eu: Remove 'u32 ref_cnt' " navin patidar
2014-05-03 11:45 ` [PATCH 14/15] staging: rtl8188eu: Remove rtl8188eu_init_recvbuf() function navin patidar
2014-05-03 11:45 ` [PATCH 15/15] staging: rtl8188eu: Remove 'u8 *pbuf' from struct recv_buf navin patidar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399117532-8521-9-git-send-email-navin.patidar@gmail.com \
--to=navin.patidar@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).