From: Yinghai Lu <yinghai@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>, Tony Luck <tony.luck@intel.com>
Cc: linux-kernel@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: [PATCH v3 2/8] sh, irq: Remove irq_reserve_irq calling
Date: Mon, 5 May 2014 18:33:20 -0700 [thread overview]
Message-ID: <1399340006-31550-3-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1399340006-31550-1-git-send-email-yinghai@kernel.org>
in sh calling path:
register_intc_controller
==> irq_create_identity_mapping/irq_create_strict_mappins
==>irq_alloc_desc: it will set bits on allocate_irq
==> intc_register_irq
==> irq_reserve_irq: set bits again
so we can kill this irq_reserve_irq calling.
-v2: Fix comment style according to Sergei Shtylyov.
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: Simon Horman <horms@verge.net.au>
Cc: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-sh@vger.kernel.org
Acked-by: Simon Horman <horms+renesas@verge.net.au>
---
drivers/sh/intc/core.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/sh/intc/core.c b/drivers/sh/intc/core.c
index 8f32a13..d146ce1 100644
--- a/drivers/sh/intc/core.c
+++ b/drivers/sh/intc/core.c
@@ -80,12 +80,7 @@ static void __init intc_register_irq(struct intc_desc *desc,
unsigned int data[2], primary;
unsigned long flags;
- /*
- * Register the IRQ position with the global IRQ map, then insert
- * it in to the radix tree.
- */
- irq_reserve_irq(irq);
-
+ /* Insert it in to the radix tree. */
raw_spin_lock_irqsave(&intc_big_lock, flags);
radix_tree_insert(&d->tree, enum_id, intc_irq_xlate_get(irq));
raw_spin_unlock_irqrestore(&intc_big_lock, flags);
--
1.8.4.5
next prev parent reply other threads:[~2014-05-06 1:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 1:33 [PATCH v3 0/8] irq: core changes for x86 ioapic hotplug Yinghai Lu
2014-05-06 1:33 ` [PATCH v3 1/8] x86, irq: Remove not needed irq_reserve_irqs calling Yinghai Lu
2014-05-06 1:33 ` Yinghai Lu [this message]
2014-05-06 1:33 ` [PATCH v3 3/8] irq: Use irq_alloc_desc_at instead of irq_reserve_irq Yinghai Lu
2014-05-06 1:33 ` [PATCH v3 4/8] s390: Mark bits in allocated_irqs in general code Yinghai Lu
2014-05-06 1:33 ` [PATCH v3 5/8] irq: Kill irq_reserve_irq/irq_reserve_irqs Yinghai Lu
2014-05-06 1:33 ` [PATCH v3 6/8] irq: Add new reserved_irqs clear/mark functions Yinghai Lu
2014-05-06 1:33 ` [PATCH v3 7/8] irq: Add irq_alloc_reserved_desc() Yinghai Lu
2014-05-06 1:33 ` [PATCH v3 8/8] irq: Do not free unallocated irq descriptors Yinghai Lu
2014-05-07 9:46 ` [PATCH v3 0/8] irq: core changes for x86 ioapic hotplug Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399340006-31550-3-git-send-email-yinghai@kernel.org \
--to=yinghai@kernel.org \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox