From: David Matlack <dmatlack@google.com>
To: gregkh@linuxfoundation.org
Cc: liodot@gmail.com, charrer@alacritech.com,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
David Matlack <dmatlack@google.com>
Subject: [PATCH 3/7] staging: slicoss: remove unused members of struct adapter
Date: Mon, 5 May 2014 21:02:33 -0700 [thread overview]
Message-ID: <1399348957-16663-4-git-send-email-dmatlack@google.com> (raw)
In-Reply-To: <1399348957-16663-1-git-send-email-dmatlack@google.com>
This patch removes two fields from the private "struct adapter".
Specifically,
memorybase duplicate of slic_regs
memorylength written once and never read. This field is trivially
computed with pci_resource_len if it's ever needed in
the future.
Signed-off-by: David Matlack <dmatlack@google.com>
---
drivers/staging/slicoss/slic.h | 2 --
drivers/staging/slicoss/slicoss.c | 4 +---
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/slicoss/slic.h b/drivers/staging/slicoss/slic.h
index 702902c..379c4f7 100644
--- a/drivers/staging/slicoss/slic.h
+++ b/drivers/staging/slicoss/slic.h
@@ -420,8 +420,6 @@ struct adapter {
ushort devid;
ushort subsysid;
u32 irq;
- void __iomem *memorybase;
- u32 memorylength;
u32 drambase;
u32 dramlength;
uint queues_initialized;
diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index 452aa02..b0b8544 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -3422,7 +3422,6 @@ static void slic_init_adapter(struct net_device *netdev,
adapter->busnumber = pcidev->bus->number;
adapter->slotnumber = ((pcidev->devfn >> 3) & 0x1F);
adapter->functionnumber = (pcidev->devfn & 0x7);
- adapter->memorylength = pci_resource_len(pcidev, 0);
adapter->slic_regs = (__iomem struct slic_regs *)memaddr;
adapter->irq = pcidev->irq;
/* adapter->netdev = netdev;*/
@@ -3431,7 +3430,6 @@ static void slic_init_adapter(struct net_device *netdev,
adapter->chipid = chip_idx;
adapter->port = 0; /*adapter->functionnumber;*/
adapter->cardindex = adapter->port;
- adapter->memorybase = memaddr;
spin_lock_init(&adapter->upr_lock.lock);
spin_lock_init(&adapter->bit64reglock.lock);
spin_lock_init(&adapter->adapter_lock.lock);
@@ -3683,7 +3681,7 @@ static int slic_entry_probe(struct pci_dev *pcidev,
slic_adapter_set_hwaddr(adapter);
- netdev->base_addr = (unsigned long)adapter->memorybase;
+ netdev->base_addr = (unsigned long) memmapped_ioaddr;
netdev->irq = adapter->irq;
netdev->netdev_ops = &slic_netdev_ops;
--
1.9.2
next prev parent reply other threads:[~2014-05-06 4:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 4:02 [PATCH 0/7] staging: slicoss: bug fixes to stabilize driver David Matlack
2014-05-06 4:02 ` [PATCH 1/7] staging: slicoss: fix use-after-free in slic_entry_probe David Matlack
2014-05-06 4:02 ` [PATCH 2/7] staging: slicoss: fix multiple free-after-free in slic_entry_remove David Matlack
2014-05-06 4:02 ` David Matlack [this message]
2014-05-06 4:02 ` [PATCH 4/7] staging: slicoss: remove gratuitous debug infrastructure David Matlack
2014-05-06 4:02 ` [PATCH 5/7] staging: slicoss: fix dma memory leak David Matlack
2014-05-06 4:02 ` [PATCH 6/7] staging: slicoss: fix 64-bit isr address bug David Matlack
2014-05-06 4:02 ` [PATCH 7/7] staging: slicoss: fix use-after-free bug in slic_entry_remove David Matlack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399348957-16663-4-git-send-email-dmatlack@google.com \
--to=dmatlack@google.com \
--cc=charrer@alacritech.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liodot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox