Re: [PATCH part2 0/6] charger/mfd: max14577: Part 2 of adding support for MAX77836

[Krzysztof Kozlowski <k.kozlowski@samsung.com>]

Hi Dmitry, David,


I need acks or reviews from power supply subsystem maintainers for
patches:
 - 1/6: charger: max14577: Add support for MAX77836 charger
 - 3/6: charger: max14577: Configure battery-dependent settings from DTS
 - 4/6: power: max17040: Add ID for MAX77836 Fuel Gauge block
These patches were published for the first time around February 2014.


Could you look at them?


Best regards,
Krzysztof


On śro, 2014-04-23 at 16:50 +0200, Krzysztof Kozlowski wrote:
> Hi,
> 
> 
> This is second part of patches adding support for MAX77836 device
> to the max14577 drivers.
> 
> The first part [1] was applied by Lee Jones [2][3] and this patchset *depends*
> on it.
> 
> This patchset changes the max14577 charger and regulator drivers
> and documents Device Tree bindings.
> 
> The patches 1 to 3 depends on each other so they should be pulled at once.
> Patches 4, 5 and 6 can be applied independently. However still the
> smoothest way to apply this would be through one tree after obtaining
> necessary acks from maintainers.
> 
> I need acks from power (patches: 1, 3, 4) and regulator (patch 5) trees.
> 
> 
> Changes since v4 (for this second part only)
> ============================================
> 1. Updated Kconfig entries mentioning MAX77836.
> 2. Added patch 5/6 (regulator: max14577: Implement SUSPEND mode for
>    MAX77836 LDO-s)
> 3. Charger: Require a charger subnode in DTS with charger settings.
>    Previously the charger driver didn't use any properties from DTS.
>    Now it needs a subnode with settings because it supports different
>    devices with different charging characteristics.
> 4. Rebased on 3.15-rc2.
> 
> Changes since v3
> ================
> 1. Applied minor fixes (pointed by Lee Jones).
> 2. Added one ACK (Lee Jones) and Review-by (Tomasz Figa).
> 3. Patch 14/charger: Minor change in parsing EOC value from DTS.
> 4. Rebased on next-20140224.
> 
> Changes since v2
> ================
> 1. Added ACK-s.
> 2. Applied minor checkpatch fixes (pointed by Lee Jones).
> 3. Rebased on next-20140217.
> 
> Changes since v1
> ================
> 1. Added ACK-s, reviews and tested-by tags.
> 2. Removed applied patches (they were merged to the linux-next tree).
> 3. Applied comments from review (Lee Jones) to 5/15 (detection of device type)
>    and 8/15 (add max77836 support to max14577).
> 4. Rebased on next tree.
> 5. Added patch 13 and 14 (pointed by Jenny Tc):
>    - regulator/mfd: max14577: Export symbols for calculating charger current
>    - charger: max14577: Configure battery-dependent settings from DTS
> 6. Updated bindings documentation with new charger bindings.
> 
> 
> References
> ==========
> [1] http://thread.gmane.org/gmane.linux.kernel/1682503
> [2] http://www.spinics.net/lists/kernel/msg1728274.html
> [3] https://git.kernel.org/cgit/linux/kernel/git/lee/mfd.git/log/?h=ib-mfd-extcon-3.16
> 
> Previous, full v4 patchset can be found here:
> http://thread.gmane.org/gmane.linux.kernel/1654267
> 
> 
> Best regards,
> Krzysztof Kozlowski
> 
> 
> Krzysztof Kozlowski (6):
>   charger: max14577: Add support for MAX77836 charger
>   regulator/mfd: max14577: Export symbols for calculating charger
>     current
>   charger: max14577: Configure battery-dependent settings from DTS
>   power: max17040: Add ID for MAX77836 Fuel Gauge block
>   regulator: max14577: Implement SUSPEND mode for MAX77836 LDO-s
>   devicetree: mfd: max14577: Add device tree bindings document
> 
>  Documentation/devicetree/bindings/mfd/max14577.txt | 152 +++++++++++
>  drivers/mfd/max14577.c                             | 100 ++++++-
>  drivers/power/Kconfig                              |   4 +-
>  drivers/power/max14577_charger.c                   | 291 ++++++++++++++++++---
>  drivers/power/max17040_battery.c                   |   1 +
>  drivers/regulator/max14577.c                       | 139 +++++-----
>  include/linux/mfd/max14577-private.h               |  92 +++++--
>  include/linux/mfd/max14577.h                       |  31 +++
>  8 files changed, 673 insertions(+), 137 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/mfd/max14577.txt
>