* [PATCH] staging : android: Fixes a coding style issue in timed_gpio.c
@ 2014-05-07 12:30 John Church
2014-05-07 12:39 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: John Church @ 2014-05-07 12:30 UTC (permalink / raw)
To: gregkh, devel, georgiana.chelu93, waydi1
Cc: dan.carpenter, linux-kernel, John Church
This patch fixes a coding style issue for a line that was over 80 characters long.
Signed-off-by: John Church <sleeveroller@gmail.com>
---
drivers/staging/android/timed_gpio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/timed_gpio.c b/drivers/staging/android/timed_gpio.c
index f7d124d..180c209 100644
--- a/drivers/staging/android/timed_gpio.c
+++ b/drivers/staging/android/timed_gpio.c
@@ -92,8 +92,8 @@ static int timed_gpio_probe(struct platform_device *pdev)
return -EBUSY;
gpio_data = devm_kzalloc(&pdev->dev,
- sizeof(struct timed_gpio_data) * pdata->num_gpios,
- GFP_KERNEL);
+ sizeof(struct timed_gpio_data) * pdata->num_gpios,
+ GFP_KERNEL);
if (!gpio_data)
return -ENOMEM;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging : android: Fixes a coding style issue in timed_gpio.c
2014-05-07 12:30 [PATCH] staging : android: Fixes a coding style issue in timed_gpio.c John Church
@ 2014-05-07 12:39 ` Dan Carpenter
2014-05-07 12:51 ` John Church
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2014-05-07 12:39 UTC (permalink / raw)
To: John Church; +Cc: gregkh, devel, georgiana.chelu93, waydi1, linux-kernel
I wonder if there is some kind of tutorial which teaches people to
choose the least specific subject possible? We should find which
tutorial it is and update it. John, can you give us a hint here which
tutorial you are using?
On Wed, May 07, 2014 at 01:30:02PM +0100, John Church wrote:
> This patch fixes a coding style issue for a line that was over 80 characters long.
>
> Signed-off-by: John Church <sleeveroller@gmail.com>
Anyway, looks ok.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging : android: Fixes a coding style issue in timed_gpio.c
2014-05-07 12:39 ` Dan Carpenter
@ 2014-05-07 12:51 ` John Church
0 siblings, 0 replies; 3+ messages in thread
From: John Church @ 2014-05-07 12:51 UTC (permalink / raw)
To: Dan Carpenter; +Cc: gregkh, devel, georgiana.chelu93, waydi1, linux-kernel
On Wed, May 07, 2014 at 03:39:15PM +0300, Dan Carpenter wrote:
> I wonder if there is some kind of tutorial which teaches people to
> choose the least specific subject possible? We should find which
> tutorial it is and update it. John, can you give us a hint here which
> tutorial you are using?
I'm doing the Eudyptula Challenge. Task 10 is to fix a coding style issue and submit it the relevant maintainers.
>
> On Wed, May 07, 2014 at 01:30:02PM +0100, John Church wrote:
> > This patch fixes a coding style issue for a line that was over 80 characters long.
> >
> > Signed-off-by: John Church <sleeveroller@gmail.com>
>
> Anyway, looks ok.
>
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> regards,
> dan carpenter
>
Thanks for your advice Dan. I've setup git send-email and mutt now so I could test the patch properly before sending.
Regards,
John
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-07 12:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-07 12:30 [PATCH] staging : android: Fixes a coding style issue in timed_gpio.c John Church
2014-05-07 12:39 ` Dan Carpenter
2014-05-07 12:51 ` John Church
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox