From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753968AbaEHLs0 (ORCPT ); Thu, 8 May 2014 07:48:26 -0400 Received: from ns.mm-sol.com ([37.157.136.199]:41961 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753832AbaEHLsZ (ORCPT ); Thu, 8 May 2014 07:48:25 -0400 Message-ID: <1399549654.8165.1.camel@iivanov-dev> Subject: Re: [PATCH 3/4] of/platform: fix device naming for non-translatable addresses From: "Ivan T. Ivanov" To: Rob Herring Cc: Grant Likely , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Josh Cartwright , Courtney Cavin , Bjorn Andersson , Frank Rowand , Rob Herring Date: Thu, 08 May 2014 14:47:34 +0300 In-Reply-To: <1399499298-8830-4-git-send-email-robherring2@gmail.com> References: <1399499298-8830-1-git-send-email-robherring2@gmail.com> <1399499298-8830-4-git-send-email-robherring2@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.1-2ubuntu2~saucy1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2014-05-07 at 16:48 -0500, Rob Herring wrote: > From: Rob Herring > > Using non-translatable addresses in platform device names is wrong > because they may not be globally unique. Just use the default naming with > a global index if the address cannot be translated instead. > > of_can_translate_address has the same checks as of_translate_address, so > we can remove it here as well. > > Reported-by: "Ivan T. Ivanov" > Cc: Josh Cartwright > Cc: Courtney Cavin > Cc: Bjorn Andersson > Cc: Frank Rowand > Cc: Grant Likely > Signed-off-by: Rob Herring Thanks. It works for me. Tested-by: Ivan T. Ivanov Regards.