* [PATCH] regulator: arizona-micsupp: Add missing #include
@ 2014-05-08 16:17 Charles Keepax
2014-05-08 17:17 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Charles Keepax @ 2014-05-08 16:17 UTC (permalink / raw)
To: broonie; +Cc: lgirdwood, arnd, patches, linux-kernel
of.h is presently being included through asm-generic/gpio.h so will not
be included on some architectures, causing implicit declaration errors
for of_get_child_by_name, of_parse_phandle and of_node_put.
This patch adds the direct include that should be there.
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
drivers/regulator/arizona-micsupp.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/regulator/arizona-micsupp.c b/drivers/regulator/arizona-micsupp.c
index b80ebbe..ce9aca5 100644
--- a/drivers/regulator/arizona-micsupp.c
+++ b/drivers/regulator/arizona-micsupp.c
@@ -16,6 +16,7 @@
#include <linux/init.h>
#include <linux/bitops.h>
#include <linux/err.h>
+#include <linux/of.h>
#include <linux/platform_device.h>
#include <linux/regulator/driver.h>
#include <linux/regulator/machine.h>
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: arizona-micsupp: Add missing #include
2014-05-08 16:17 [PATCH] regulator: arizona-micsupp: Add missing #include Charles Keepax
@ 2014-05-08 17:17 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-05-08 17:17 UTC (permalink / raw)
To: Charles Keepax; +Cc: lgirdwood, arnd, patches, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 291 bytes --]
On Thu, May 08, 2014 at 05:17:38PM +0100, Charles Keepax wrote:
> of.h is presently being included through asm-generic/gpio.h so will not
> be included on some architectures, causing implicit declaration errors
> for of_get_child_by_name, of_parse_phandle and of_node_put.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-08 17:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-08 16:17 [PATCH] regulator: arizona-micsupp: Add missing #include Charles Keepax
2014-05-08 17:17 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox