From: Keith Busch <keith.busch@intel.com>
To: linux-nvme@lists.infradead.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Cc: Keith Busch <keith.busch@intel.com>
Subject: [PATCH 1/2] driver-core: allow asynchronous device shutdown
Date: Thu, 8 May 2014 12:07:33 -0600 [thread overview]
Message-ID: <1399572454-30239-2-git-send-email-keith.busch@intel.com> (raw)
In-Reply-To: <1399572454-30239-1-git-send-email-keith.busch@intel.com>
A patch to allow .shutdown to execute asynchronously. Some devices may
take a long time to complete a shutdown, so this patch lets a driver
safely shutdown multiple devices asynchronously.
This uses an exclusive asynchronous domain so other unrelated async
tasks can't cause shutdown to hold up indefinitely.
Signed-off-by: Keith Busch <keith.busch@intel.com>
---
drivers/base/core.c | 4 ++++
include/linux/device.h | 1 +
2 files changed, 5 insertions(+)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index 20da3ad..71b83bb 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -10,6 +10,7 @@
*
*/
+#include <linux/async.h>
#include <linux/device.h>
#include <linux/err.h>
#include <linux/init.h>
@@ -1926,6 +1927,8 @@ out:
}
EXPORT_SYMBOL_GPL(device_move);
+ASYNC_DOMAIN_EXCLUSIVE(shutdown_domain);
+EXPORT_SYMBOL(shutdown_domain);
/**
* device_shutdown - call ->shutdown() on each device to shutdown.
*/
@@ -1986,6 +1989,7 @@ void device_shutdown(void)
spin_lock(&devices_kset->list_lock);
}
spin_unlock(&devices_kset->list_lock);
+ async_synchronize_full_domain(&shutdown_domain);
}
/*
diff --git a/include/linux/device.h b/include/linux/device.h
index d1d1c05..95ed9f1 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -997,6 +997,7 @@ static inline int devtmpfs_mount(const char *mountpoint) { return 0; }
/* drivers/base/power/shutdown.c */
extern void device_shutdown(void);
+extern struct async_domain shutdown_domain;
/* debugging and troubleshooting/diagnostic helpers. */
extern const char *dev_driver_string(const struct device *dev);
--
1.7.10.4
next prev parent reply other threads:[~2014-05-08 18:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 18:07 [PATCH 0/2] Asynchronous device shutdown Keith Busch
2014-05-08 18:07 ` Keith Busch [this message]
2014-05-08 19:03 ` [PATCH 1/2] driver-core: allow asynchronous " Greg KH
2014-05-08 18:07 ` [PATCH 2/2] NVMe: Complete shutdown asynchronously Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399572454-30239-2-git-send-email-keith.busch@intel.com \
--to=keith.busch@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox