From: Jason Low <jason.low2@hp.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org,
alex.shi@linaro.org, preeti@linux.vnet.ibm.com, efault@gmx.de,
vincent.guittot@linaro.org, morten.rasmussen@arm.com,
aswin@hp.com, jason.low2@hp.com
Subject: Re: [PATCH 2/2] sched: Fix next_balance logic in rebalance_domains() and idle_balance()
Date: Fri, 09 May 2014 10:29:00 -0700 [thread overview]
Message-ID: <1399656540.2169.20.camel@j-VirtualBox> (raw)
In-Reply-To: <20140509090805.GK30445@twins.programming.kicks-ass.net>
On Fri, 2014-05-09 at 11:08 +0200, Peter Zijlstra wrote:
> On Thu, May 08, 2014 at 05:49:22PM -0700, Jason Low wrote:
> > On Thu, 2014-05-08 at 15:14 -0700, Jason Low wrote:
> > > Hi Ingo, Peter,
> > >
> > > Were there NULL domains on the test system? If so, I think we can
> > > address the problem by doing update_next_balance() only if the below
> > > rcu_dereference_check_sched_domain() returns a non-null domain.
> >
> > Also, below is a patch which has the change:
> >
>
> Thanks, and yes, NULL domains are a perfectly normal thing to have
> (though not common on normal boot paths).
Okay. Likewise, on my test machine, I offline all but 1 CPU
in order to try reproducing the issue.
Thanks,
Jason
next prev parent reply other threads:[~2014-05-09 17:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 22:45 [PATCH 0/2] sched: Idle load balance fixes Jason Low
2014-04-28 22:45 ` [PATCH 1/2] sched: Fix updating rq->max_idle_balance_cost and rq->next_balance in idle_balance() Jason Low
2014-05-08 10:42 ` [tip:sched/core] sched: Fix updating rq-> max_idle_balance_cost " tip-bot for Jason Low
2014-04-28 22:45 ` [PATCH 2/2] sched: Fix next_balance logic in rebalance_domains() and idle_balance() Jason Low
2014-05-08 16:59 ` Jason Low
2014-05-08 17:38 ` Ingo Molnar
2014-05-08 18:15 ` Jason Low
2014-05-08 22:14 ` Jason Low
2014-05-09 0:49 ` Jason Low
2014-05-09 9:08 ` Peter Zijlstra
2014-05-09 17:29 ` Jason Low [this message]
2014-05-19 13:09 ` [tip:sched/core] " tip-bot for Jason Low
2014-05-22 12:27 ` [tip:sched/core] sched: Fix the rq-> " tip-bot for Jason Low
2014-05-08 18:06 ` [PATCH 2/2] sched: Fix " Peter Zijlstra
2014-04-30 7:54 ` [PATCH 0/2] sched: Idle load balance fixes Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399656540.2169.20.camel@j-VirtualBox \
--to=jason.low2@hp.com \
--cc=alex.shi@linaro.org \
--cc=aswin@hp.com \
--cc=daniel.lezcano@linaro.org \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=preeti@linux.vnet.ibm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox