From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5FFB42640A for ; Mon, 27 Jul 2026 16:37:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785170254; cv=none; b=kXXphrqrDFcT0gusC0/Kq8vZEk9MujCJoBJ9+WsKY4hDeJn06sguBqh+bdung/uP4iezxvaoSm/ccuo0DgOvKyn5G2Wnz+8FuLtBHxBogZZzPq48tLzABqlIjskbFsdEfUnOUO30XAf/CzzHTfdF8uFEYDW1gPp445e5ixMgehg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785170254; c=relaxed/simple; bh=Je5rToflP6HDFUwILHyTwGD80qHDZtt3u766+IEEhbU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bKC3FS4reCP+JPgzaz5zSYMns7kPFUzzet2NdBUup4gmogQy0bYkGrQvzJ+mlR6K0jAnZECG3yGvpSBIhusXUoIAaVgT6IZXmSDb2BtKba5LDApm/pd4qmMhs3PXZQ6wTlnHhMT7akL96+RbfeHl0sYzwOi51zLp05U370rk3TI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l/mzTCgG; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l/mzTCgG" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-384930ca5e2so2740091a91.3 for ; Mon, 27 Jul 2026 09:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785170251; x=1785775051; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RNfPUvmh9SATlz6mHMfXelOb20yzwkWrtvzrS+ab4jI=; b=l/mzTCgGLY9QQPJuLopMuGDUmXew7tTcMj+24iIXk1wWoDJZrl9X57G6yDXO6apXeq oh+lvvK5PNpayIw53/1RJCgb/+UFoyJ2M0aKlDoLPK+kt7Wg63e8v10zAHmZiEWYKSAr B4WiRe1GxcX/os/aKRHKCtZihbiDBcijWtsVdtv3/YuZd1iX5sbg8Xbn2+ztAr3oxG8y wm8P6VUjPWB1avjRzdm9eT4lN/Idd08l1bcm6ig3sKadkNgEDFTbN+C357vtsvmQo8DD O+wg3mAmINtvw2Rqx6mfLY1poMt9MKNkTLLLXdj4IhLjHxfEvIF9OtU2/CawqN8SD+GC MSOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785170251; x=1785775051; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RNfPUvmh9SATlz6mHMfXelOb20yzwkWrtvzrS+ab4jI=; b=r55qmnxo5IaDU4h4kp3DnySmW079tlMYLO6E5BffCoGjsAEmyo0pa4CbAyF1spGDil wDNUypZtKpq3+xsSH5UsnlDWnQnCcUwnjHzEziMR/NAENiVrIJ78rGNJGa0+1Vb5og8Z Zhs0VJdbs/74uGAbJc5w5Wk+G3SBJoaByiy4+mU9k7WIVZAC+QasX8YNieKrRHy6Cc/y 7oD8gYbiLil1wUWGMGVd+0Rv2DWDXCutYk7p9s+qeXw+gI8g/CK4BVW2txrzf9r+5MDw uJPaAcv5HZCyl7m/Tcc3D1V6G2BzkRYu4F8IwDzOcy+4TibIJ8ecSClTcL+MEIkXNS4G LMOw== X-Gm-Message-State: AOJu0YzGiT04/UdSeMEUklkuJ/vJDKLOtQoNQyQIb+vvKhOlOXOTutgk Aw9w+4OT9nq3ywyDIcjpnDR12K0XgKiRNPeswKV/22ZOpPV4bIeNiJJN X-Gm-Gg: AR+sD13/nMKFUYq8JgU6v8dhyx37qnNp7X7Pw9iJm399SxuMepd5P4bqWXW0ky12630 EAK2F9aEawNkRHLfc7f1GwHepyEOSt3S4giVodFgsP4bqhN0b6/pWzEyEGeUCTVqfVkkk93GsDo PwvmMkDwNgfsa/CyehVgJfUT3akGM2jiB55azAQUDizxtKEPcyHQ5UJeoQYJKZMkS+s4CTGTa+F 0J2fAJa+M39tuRXrXPtTMFcXfs2tEXSOfTRjXng8C0p5OgHFm71gDrfA4srRKwLil7yCE+uXVpo XQKs0pxz/xrtg4EGYmkYQ01ugNHDxyHeKoIvR6s/jDcl0OjQ4vGyndmq8klshsGO5vhohaSki2/ c9dUlZBi+Q1ih0YMd4sOywDdtIB4sdEaMu6YtUYtIoPA5EtYNUFBmp1qJzjbWN62PlYFMtpRv8g 8I8Gi/7SRcQkBBe95jUgPeRo35bSdB X-Received: by 2002:a17:90b:1fc8:b0:36a:5d1f:7b6 with SMTP id 98e67ed59e1d1-38f293cd148mr7722475a91.2.1785170251220; Mon, 27 Jul 2026 09:37:31 -0700 (PDT) Received: from [172.24.233.249] ([163.114.132.133]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13e6054598asm14951111c88.1.2026.07.27.09.37.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jul 2026 09:37:30 -0700 (PDT) Message-ID: <13ebe4e4-d744-4473-bc6e-2742ac0af492@gmail.com> Date: Mon, 27 Jul 2026 09:37:27 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v12 2/8] hinic3: Fix loose success check in rx buffer filling To: Fan Gong , Wu Di , Teng Peisen , netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Andrew Lunn , Ioana Ciornei , Dimitri Daskalakis , Harshitha Ramamurthy Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Chen Anwen , He Wei , luosifu , Xin Guo , Zhou Shuai , Wu Like , Shi Jing , Zheng Jiezhen , Maxime Chevallier References: <9463522667ee175211c12e8ecd7c81a0a55256b6.1785120952.git.root@localhost.localdomain> Content-Language: en-US From: Mohsin Bashir In-Reply-To: <9463522667ee175211c12e8ecd7c81a0a55256b6.1785120952.git.root@localhost.localdomain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/26/26 11:54 PM, Fan Gong wrote: > Tightens the success criterion for hinic3_rx_fill_buffers() in > hinic3_configure_rxqs(). > > Co-developed-by: Wu Di > Signed-off-by: Wu Di > Co-developed-by: Teng Peisen > Signed-off-by: Teng Peisen > Signed-off-by: Fan Gong > --- > drivers/net/ethernet/huawei/hinic3/hinic3_rx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c b/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c > index 309ab5901379..389b1c2158be 100644 > --- a/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c > +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c > @@ -541,7 +541,7 @@ int hinic3_configure_rxqs(struct net_device *netdev, u16 num_rq, > rq_associate_cqes(rxq); > > pkts = hinic3_rx_fill_buffers(rxq); > - if (!pkts) { > + if (pkts < rxq->q_mask) { > netdev_err(netdev, "Failed to fill Rx buffer\n"); > return -ENOMEM; > } Given the subject, curious if a partially populated ring result in any functional failure? if so, then perhaps failure mode can be explained and this specific change be sent to net tree?