Re: [PATCH] platform/x86: dell-laptop: Implement platform_profile

[srinivas pandruvada <srinivas.pandruvada@linux.intel.com>]

On Thu, 2024-04-25 at 14:24 -0600, Lyndon Sanche wrote:
> On Thu, Apr 25, 2024, at 2:07 PM, Mario Limonciello wrote:
> > + Srinivas
> > 
> > On 4/25/2024 12:27, Lyndon Sanche wrote:
> > > Some Dell laptops support configuration of preset
> > > fan modes through smbios tables.
> > > 
> > > If the platform supports these fan modes, set up
> > > platform_profile to change these modes. If not
> > > supported, skip enabling platform_profile.
> > > 
> > > Signed-off-by: Lyndon Sanche <lsanche@lyndeno.ca>
> > > ---
> > 
> > When you developed this was it using a Dell Intel or Dell AMD
> > system?
> > 
> > If it was an Intel system, did you test it with thermald installed
> > and 
> > active?
> > 
> > I'm wondering how all this stuff jives with the stuff that thermald
> > does.  I don't know if they fight for any of the same "resources".
> 
> Thank you for your response.
> 
> I did my development and testing on a Dell Intel system. Specifically
> the XPS 15 9560 with i7-7700HQ.
> 
> I do have thermald running, though I admit I am not really aware of
> what exactly it does, besides being related to thermals in some way.
> 
> I normally set the thermal mode with Dell's smbios-thermal-ctl
> program. I am not too sure all the values that the bios configures on
> it's own depending on the provided mode, so I am not sure if thermald
> conflicts. But my understanding is that would be out of scope of this
> driver, since we are only telling the bios what we want at a high
> level.
> 
> Lyndon
Can you share output of acpidump tool to me? I want to make sure if
there is some way the platform will bypass thermal table if you changed
to some profile.

Thanks,
Srinivas