From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757608AbaEPQph (ORCPT ); Fri, 16 May 2014 12:45:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50562 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757519AbaEPQpf (ORCPT ); Fri, 16 May 2014 12:45:35 -0400 Message-ID: <1400258705.21547.217.camel@deneb.redhat.com> Subject: Re: [PATCH v4 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support. From: Mark Salter To: Iyappan Subramanian Cc: davem@davemloft.net, netdev@vger.kernel.org, devicetree@vger.kernel.org, jcm@redhat.com, gregkh@linuxfoundation.org, patches@apm.com, linux-kernel@vger.kernel.org, Keyur Chudgar , linux-arm-kernel@lists.infradead.org, Ravi Patel Date: Fri, 16 May 2014 12:45:05 -0400 In-Reply-To: <1399326447-2329-5-git-send-email-isubramanian@apm.com> References: <1399326447-2329-1-git-send-email-isubramanian@apm.com> <1399326447-2329-5-git-send-email-isubramanian@apm.com> Organization: Red Hat, Inc Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2014-05-05 at 14:47 -0700, Iyappan Subramanian wrote: > +static int xgene_enet_probe(struct platform_device *pdev) > +{ > + struct net_device *ndev; > + struct xgene_enet_pdata *pdata; > + struct device *dev = &pdev->dev; > + struct napi_struct *napi; > + int ret = 0; > + > + ndev = alloc_etherdev(sizeof(struct xgene_enet_pdata)); > + if (!ndev) > + return -ENOMEM; > + > + pdata = netdev_priv(ndev); > + > + pdata->pdev = pdev; > + pdata->ndev = ndev; > + SET_NETDEV_DEV(ndev, dev); > + platform_set_drvdata(pdev, pdata); > + ndev->netdev_ops = &xgene_ndev_ops; > + ndev->features |= NETIF_F_IP_CSUM; > + ndev->features |= NETIF_F_GSO; > + ndev->features |= NETIF_F_GRO; > + You're missing: spin_lock_init(&pdata->stats_lock); Lockdep (if enabled) complains: xgene_enet_probe: 852 INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. CPU: 4 PID: 1 Comm: swapper/0 Not tainted 3.15.0-rc4+ #13 Call trace: [] dump_backtrace+0x0/0x16c [] show_stack+0x10/0x1c [] dump_stack+0x88/0xb8 [] __lock_acquire+0x1914/0x1ce0 [] lock_acquire+0x9c/0x1d0 [] _raw_spin_lock+0x40/0x58 [] xgene_enet_get_stats+0x34/0x140 [] dev_get_stats+0x90/0xbc [] rtnl_fill_ifinfo+0x388/0x8e4 [] rtmsg_ifinfo+0x70/0x10c [] register_netdevice+0x370/0x400 [] register_netdev+0x14/0x2c [] xgene_enet_probe+0x1cc/0x618 [] platform_drv_probe+0x28/0x80 [] driver_probe_device+0x98/0x3ac [] __driver_attach+0xa0/0xa8 [] bus_for_each_dev+0x54/0x98 [] driver_attach+0x1c/0x28 [] bus_add_driver+0x164/0x240 [] driver_register+0x64/0x130 [] __platform_driver_register+0x5c/0x68 [] xgene_enet_driver_init+0x14/0x20 [] do_one_initcall+0xc4/0x154 [] kernel_init_freeable+0x204/0x2a8 [] kernel_init+0xc/0xd4 > + ret = xgene_enet_get_resources(pdata); > + if (ret) > + goto err; > + > + ret = register_netdev(ndev);