From: David Howells <dhowells@redhat.com>
To: Christian Schoenebeck <linux_oss@crudebyte.com>
Cc: dhowells@redhat.com, Eric Van Hensbergen <ericvh@kernel.org>,
Dominique Martinet <asmadeus@codewreck.org>,
Latchesar Ionkov <lucho@ionkov.net>,
Matthew Wilcox <willy@infradead.org>,
Jeff Layton <jlayton@kernel.org>,
Christian Brauner <christian@brauner.io>,
netfs@lists.linux.dev, v9fs@lists.linux.dev,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/3] 9p: Further netfslib-related changes
Date: Mon, 29 Jan 2024 14:22:15 +0000 [thread overview]
Message-ID: <1400271.1706538135@warthog.procyon.org.uk> (raw)
In-Reply-To: <1726980.McBZPkGeyK@silver>
Christian Schoenebeck <linux_oss@crudebyte.com> wrote:
> > (1) Enable large folio support for 9p. This is handled entirely by
> > netfslib and is already supported in afs. I wonder if we should limit
> > the maximum folio size to 1MiB to match the maximum I/O size in the 9p
> > protocol.
>
> The limit depends on user's 'msize' 9p client option and on the 9p transport
> implementation. The hard limit with virtio transport for instance is currently
> just 500k (patches for virtio 4MB limit fetching dust unfortunately).
Okay. Is that 500KiB or 512Kib?
> Would you see an advantage to limit folio size? I mean p9_client_read() etc.
> are automatically limiting the read/write chunk size accordingly.
For reads not so much, but for writes it would mean that a dirty folio is
either entirely written or entirely failed. I don't know how important this
would be for the 9p usecases.
David
next prev parent reply other threads:[~2024-01-29 14:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 11:54 [RFC PATCH 0/3] 9p: Further netfslib-related changes David Howells
2024-01-29 11:54 ` [RFC PATCH 1/3] 9p: Enable large folio support David Howells
2024-01-29 11:54 ` [RFC PATCH 2/3] 9p: Make better use of netfslib's writethrough caching David Howells
2024-01-29 11:54 ` [RFC PATCH 3/3] 9p: Always update remote_i_size in stat2inode David Howells
2024-01-29 14:14 ` [RFC PATCH 0/3] 9p: Further netfslib-related changes Christian Schoenebeck
2024-01-29 14:22 ` David Howells [this message]
2024-01-29 20:53 ` Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400271.1706538135@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=asmadeus@codewreck.org \
--cc=christian@brauner.io \
--cc=ericvh@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=netfs@lists.linux.dev \
--cc=v9fs@lists.linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox