* [PATCH] clk: twl6040: Convert to use devm_clk_register
@ 2014-05-18 15:42 Axel Lin
2014-05-19 16:32 ` Peter Ujfalusi
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2014-05-18 15:42 UTC (permalink / raw)
To: Mike Turquette; +Cc: Peter Ujfalusi, linux-kernel
Use devm_clk_register() to simplify the code by removing twl6040_clk_remove().
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/clk/clk-twl6040.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/clk/clk-twl6040.c b/drivers/clk/clk-twl6040.c
index 1ada79a..9e996b4 100644
--- a/drivers/clk/clk-twl6040.c
+++ b/drivers/clk/clk-twl6040.c
@@ -91,7 +91,7 @@ static int twl6040_clk_probe(struct platform_device *pdev)
clkdata->twl6040 = twl6040;
clkdata->mcpdm_fclk.init = &wm831x_clkout_init;
- clkdata->clk = clk_register(&pdev->dev, &clkdata->mcpdm_fclk);
+ clkdata->clk = devm_clk_register(&pdev->dev, &clkdata->mcpdm_fclk);
if (IS_ERR(clkdata->clk))
return PTR_ERR(clkdata->clk);
@@ -100,22 +100,12 @@ static int twl6040_clk_probe(struct platform_device *pdev)
return 0;
}
-static int twl6040_clk_remove(struct platform_device *pdev)
-{
- struct twl6040_clk *clkdata = platform_get_drvdata(pdev);
-
- clk_unregister(clkdata->clk);
-
- return 0;
-}
-
static struct platform_driver twl6040_clk_driver = {
.driver = {
.name = "twl6040-clk",
.owner = THIS_MODULE,
},
.probe = twl6040_clk_probe,
- .remove = twl6040_clk_remove,
};
module_platform_driver(twl6040_clk_driver);
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: twl6040: Convert to use devm_clk_register
2014-05-18 15:42 [PATCH] clk: twl6040: Convert to use devm_clk_register Axel Lin
@ 2014-05-19 16:32 ` Peter Ujfalusi
0 siblings, 0 replies; 2+ messages in thread
From: Peter Ujfalusi @ 2014-05-19 16:32 UTC (permalink / raw)
To: Axel Lin, Mike Turquette; +Cc: linux-kernel
On 05/18/2014 06:42 PM, Axel Lin wrote:
> Use devm_clk_register() to simplify the code by removing twl6040_clk_remove().
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/clk/clk-twl6040.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/clk/clk-twl6040.c b/drivers/clk/clk-twl6040.c
> index 1ada79a..9e996b4 100644
> --- a/drivers/clk/clk-twl6040.c
> +++ b/drivers/clk/clk-twl6040.c
> @@ -91,7 +91,7 @@ static int twl6040_clk_probe(struct platform_device *pdev)
> clkdata->twl6040 = twl6040;
>
> clkdata->mcpdm_fclk.init = &wm831x_clkout_init;
> - clkdata->clk = clk_register(&pdev->dev, &clkdata->mcpdm_fclk);
> + clkdata->clk = devm_clk_register(&pdev->dev, &clkdata->mcpdm_fclk);
> if (IS_ERR(clkdata->clk))
> return PTR_ERR(clkdata->clk);
>
> @@ -100,22 +100,12 @@ static int twl6040_clk_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static int twl6040_clk_remove(struct platform_device *pdev)
> -{
> - struct twl6040_clk *clkdata = platform_get_drvdata(pdev);
> -
> - clk_unregister(clkdata->clk);
> -
> - return 0;
> -}
> -
> static struct platform_driver twl6040_clk_driver = {
> .driver = {
> .name = "twl6040-clk",
> .owner = THIS_MODULE,
> },
> .probe = twl6040_clk_probe,
> - .remove = twl6040_clk_remove,
> };
>
> module_platform_driver(twl6040_clk_driver);
>
--
Péter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-19 16:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-18 15:42 [PATCH] clk: twl6040: Convert to use devm_clk_register Axel Lin
2014-05-19 16:32 ` Peter Ujfalusi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox