From: Joe Perches <joe@perches.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
akpm <akpm@linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 1/1] fs/jffs2/compr.c: remove 0 assignment on static
Date: Mon, 19 May 2014 12:53:19 -0700 [thread overview]
Message-ID: <1400529199.14238.24.camel@joe-AO725> (raw)
In-Reply-To: <20140519213145.e75dbd1aa74fc2ccd9193686@skynet.be>
On Mon, 2014-05-19 at 21:31 +0200, Fabian Frederick wrote:
> static values are automatically initialized to NULL
[]
> diff --git a/fs/jffs2/compr.c b/fs/jffs2/compr.c
[]
> @@ -25,7 +25,8 @@ static LIST_HEAD(jffs2_compressor_list);
> static int jffs2_compression_mode = JFFS2_COMPR_MODE_PRIORITY;
>
> /* Statistics for blocks stored without compression */
> -static uint32_t none_stat_compr_blocks=0,none_stat_decompr_blocks=0,none_stat_compr_size=0;
> +static uint32_t none_stat_compr_blocks, none_stat_decompr_blocks,
> + none_stat_compr_size;
Maybe nicer on 3 lines.
static uint32_t none_stat_compr_blocks;
static uint32_t none_stat_decompr_blocks,
static uint32_t none_stat_compr_size;
These none_stat_<foo> variables seem to
be write only so it'd probably be better
to remove them instead.
Maybe all the uint32_t uses in fs/jffs2/
would be nicer as u32.
next prev parent reply other threads:[~2014-05-19 19:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 19:31 [PATCH 1/1] fs/jffs2/compr.c: remove 0 assignment on static Fabian Frederick
2014-05-19 19:53 ` Joe Perches [this message]
2014-05-19 19:56 ` David Woodhouse
2014-05-19 20:01 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400529199.14238.24.camel@joe-AO725 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox