From: Joe Perches <joe@perches.com>
To: Tejun Heo <tj@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Kay Sievers <kay@vrfy.org>,
Ron <ron@debian.org>, Ben Hutchings <ben@decadent.org.uk>
Subject: Re: [PATCH driver-core-linus] sysfs: make sure read buffer is zeroed
Date: Mon, 19 May 2014 18:25:40 -0700 [thread overview]
Message-ID: <1400549140.19786.6.camel@joe-AO725> (raw)
In-Reply-To: <20140520004955.GA30633@mtj.dyndns.org>
On Mon, 2014-05-19 at 20:49 -0400, Tejun Heo wrote:
> On Mon, May 19, 2014 at 03:32:22PM -0700, Joe Perches wrote:
> > > > + memset(buf, 0, PAGE_SIZE);
> >
> > memset(buf, 0, count)?
>
> It's always PAGE_SIZE. Outputs longer than that are truncated.
Yeah, I know, but the code and comment above it don't match.
/* acquire buffer and ensure that it's >= PAGE_SIZE and clear */
prev parent reply other threads:[~2014-05-20 1:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140519172334.GK20439@audi.shelbyville.oz>
2014-05-19 19:52 ` [PATCH driver-core-linus] sysfs: make sure read buffer is zeroed Tejun Heo
2014-05-19 22:25 ` Greg Kroah-Hartman
2014-05-19 22:32 ` Joe Perches
2014-05-20 0:49 ` Tejun Heo
2014-05-20 1:25 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400549140.19786.6.camel@joe-AO725 \
--to=joe@perches.com \
--cc=ben@decadent.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=kay@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ron@debian.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox