Re: [PATCH] MIPS: remove checks for CONFIG_SGI_IP35

[Paul Bolle <pebolle@tiscali.nl>]

On Thu, 2014-05-22 at 15:12 +0200, Ralf Baechle wrote:
> On Tue, May 20, 2014 at 01:21:49PM +0200, Paul Bolle wrote:
> 
> > Ever since (shortly before) v2.4.0 there have been checks for
> > CONFIG_SGI_IP35. But a Kconfig symbol SGI_IP35 was never added to the
> > tree. Remove these checks.
> > 
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > ---
> > Untested.
> > 
> > For some reason CONFIG_SGI_IP35 was heavily used in arch/ia64 too.
> > Anyhow, IA64 has dropped that macro years ago.
> 
> The #ifdefs exist because these headers are originally from IRIX and the
> equivalent IRIX definitions were converted to Linux-style.  For the
> IA64 version keeping those ifdefs around obviously made no sense since -
> since IP35 (Origin 300/3000 series) is MIPS-based, so it was dropped
> again.

Nice to know. Thanks.

> There is some out-of-tree support for IP35 so I'd like to drop this
> patch.

Thanks for handling this (and the similar) patches so quickly. I
disagree with your decision here. But there are many, many issues like
this still left in the tree. So there's no point in making noise about
just this one Kconfig macro.

By the way, could you perhaps look at CONFIG_SYS_HAS_CPU_RM9000? It
seems the Kconfig entry for SYS_HAS_CPU_RM9000 is simply missing. But
the CPU support code is rather complicated and I stopped trying to
understand it after staring at it for way too long.

Thanks again,


Paul Bolle