From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753435AbaEWPQK (ORCPT ); Fri, 23 May 2014 11:16:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35722 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752302AbaEWPQD (ORCPT ); Fri, 23 May 2014 11:16:03 -0400 From: Jiri Olsa To: linux-kernel@vger.kernel.org Cc: Arnaldo Carvalho de Melo , Corey Ashford , David Ahern , Frederic Weisbecker , Ingo Molnar , Namhyung Kim , Paul Mackerras , Peter Zijlstra , Stephane Eranian , Jiri Olsa Subject: [RFC/PATCH 0/2] perf tools: Factor sort elide Date: Fri, 23 May 2014 17:15:45 +0200 Message-Id: <1400858147-7155-1-git-send-email-jolsa@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hi, factoring the elide code to make perf_hpp__should_skip function cheap call/check again. Also I was wondering.. do we want to get rid of sort_entry structs in favor of perf_hpp__* stuff? Any plans? I'm sending this a RFC, since any other such refactoring would change this stuff for sure as well ;-). thanks, jirka Cc: Arnaldo Carvalho de Melo Cc: Corey Ashford Cc: David Ahern Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Stephane Eranian Signed-off-by: Jiri Olsa --- tools/perf/ui/browsers/hists.c | 8 ++++---- tools/perf/util/hist.h | 8 +++++++- tools/perf/util/sort.c | 102 +++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------- tools/perf/util/sort.h | 2 +- 4 files changed, 67 insertions(+), 53 deletions(-)