public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] regulator: ltc3589: Fix module dependency
@ 2014-05-27  5:51 Axel Lin
  2014-05-27  9:30 ` Philipp Zabel
  2014-05-27 11:07 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2014-05-27  5:51 UTC (permalink / raw)
  To: Mark Brown; +Cc: Philipp Zabel, Liam Girdwood, Stephen Rothwell, linux-kernel

Make this driver depend on I2C and select REGMAP_I2C to fix build failure.
Also allows this driver to be built as module.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/regulator/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index 8f5c880..c2fa0b4 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -273,7 +273,9 @@ config REGULATOR_LP8788
 	  This driver supports LP8788 voltage regulator chip.
 
 config REGULATOR_LTC3589
-	bool "LTC3589 8-output voltage regulator"
+	tristate "LTC3589 8-output voltage regulator"
+	depends on I2C
+	select REGMAP_I2C
 	help
 	  This enables support for the LTC3589, LTC3589-1, and LTC3589-2
 	  8-output regulators controlled via I2C.
-- 
1.8.3.2




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] regulator: ltc3589: Fix module dependency
  2014-05-27  5:51 [PATCH] regulator: ltc3589: Fix module dependency Axel Lin
@ 2014-05-27  9:30 ` Philipp Zabel
  2014-05-27 11:07 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Philipp Zabel @ 2014-05-27  9:30 UTC (permalink / raw)
  To: Axel Lin; +Cc: Mark Brown, Liam Girdwood, Stephen Rothwell, linux-kernel

Am Dienstag, den 27.05.2014, 13:51 +0800 schrieb Axel Lin:
> Make this driver depend on I2C and select REGMAP_I2C to fix build failure.
> Also allows this driver to be built as module.
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

> ---
>  drivers/regulator/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> index 8f5c880..c2fa0b4 100644
> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -273,7 +273,9 @@ config REGULATOR_LP8788
>  	  This driver supports LP8788 voltage regulator chip.
>  
>  config REGULATOR_LTC3589
> -	bool "LTC3589 8-output voltage regulator"
> +	tristate "LTC3589 8-output voltage regulator"
> +	depends on I2C
> +	select REGMAP_I2C

thanks
Philipp


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] regulator: ltc3589: Fix module dependency
  2014-05-27  5:51 [PATCH] regulator: ltc3589: Fix module dependency Axel Lin
  2014-05-27  9:30 ` Philipp Zabel
@ 2014-05-27 11:07 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-05-27 11:07 UTC (permalink / raw)
  To: Axel Lin; +Cc: Philipp Zabel, Liam Girdwood, Stephen Rothwell, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

On Tue, May 27, 2014 at 01:51:49PM +0800, Axel Lin wrote:
> Make this driver depend on I2C and select REGMAP_I2C to fix build failure.
> Also allows this driver to be built as module.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-05-27 11:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-27  5:51 [PATCH] regulator: ltc3589: Fix module dependency Axel Lin
2014-05-27  9:30 ` Philipp Zabel
2014-05-27 11:07 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox