* [PATCH RESEND] regulator: arizona-ldo1: add missing #include
@ 2014-05-27 12:00 Charles Keepax
2014-05-27 15:06 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Charles Keepax @ 2014-05-27 12:00 UTC (permalink / raw)
To: broonie; +Cc: lgirdwood, arnd, patches, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
commit 2cce4be9e6b8 "regulator: arizona-ldo1: Add processing of init_data
from device tree" added a call to of_get_child_by_name() but
did not add an #include to the header file declaring that function.
I got a build error when doing randconfig testing on this, which
is fixed by this patch to include of.h.
drivers/regulator/arizona-ldo1.c:192:2: error: implicit declaration of function 'of_get_child_by_name' [-Werror=implicit-function-declaration]
drivers/regulator/arizona-ldo1.c:193:2: error: implicit declaration of function 'of_parse_phandle' [-Werror=implicit-function-declaration]
drivers/regulator/arizona-ldo1.c:213:2: error: implicit declaration of function 'of_node_put' [-Werror=implicit-function-declaration]
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: Mark Brown <broonie@linaro.org>
---
Hi,
I think this patch got missed when Arnd Bergmann sent it in,
I hope no one minds me resending it to make sure it gets
applied.
Thanks,
Charles
drivers/regulator/arizona-ldo1.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/regulator/arizona-ldo1.c b/drivers/regulator/arizona-ldo1.c
index d3787e1..04f262a 100644
--- a/drivers/regulator/arizona-ldo1.c
+++ b/drivers/regulator/arizona-ldo1.c
@@ -16,6 +16,7 @@
#include <linux/init.h>
#include <linux/bitops.h>
#include <linux/err.h>
+#include <linux/of.h>
#include <linux/platform_device.h>
#include <linux/regulator/driver.h>
#include <linux/regulator/machine.h>
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] regulator: arizona-ldo1: add missing #include
2014-05-27 12:00 [PATCH RESEND] regulator: arizona-ldo1: add missing #include Charles Keepax
@ 2014-05-27 15:06 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-05-27 15:06 UTC (permalink / raw)
To: Charles Keepax; +Cc: lgirdwood, arnd, patches, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
On Tue, May 27, 2014 at 01:00:10PM +0100, Charles Keepax wrote:
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> Cc: Mark Brown <broonie@linaro.org>
> I think this patch got missed when Arnd Bergmann sent it in,
> I hope no one minds me resending it to make sure it gets
> applied.
I can't apply this since you haven't signed it off. Arnd, let me once
again remind you to send patches to maintainers.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-27 15:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-27 12:00 [PATCH RESEND] regulator: arizona-ldo1: add missing #include Charles Keepax
2014-05-27 15:06 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox